Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <3A834364.82BB70C7@cygnus.com>
Date: Thu, 08 Feb 2001 20:09:56 -0500
From: "J. Johnston" <jjohnstn AT cygnus DOT com>
Organization: Red Hat Inc.
X-Mailer: Mozilla 4.7 [en] (X11; U; Linux 2.2.12-20 i686)
X-Accept-Language: en
MIME-Version: 1.0
To: edward <tailbert AT yahoo DOT com>
CC: newlib AT sources DOT redhat DOT com, cygwin AT sources DOT redhat DOT com
Subject: Re: Updated headers (take 2)
References: <20010207064226 DOT 26176 DOT qmail AT web310 DOT mail DOT yahoo DOT com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

edward wrote:
> 
> Sorry! I cvs diff'd against a test directory, instead of the actual cvs
> directory. Enclosed are the real patches. Also, removed duplicate
> prototypes for getw/putw in stdio.h. Diff's against updates as of
> midnight.
> 
> Enclosed are patches to header files for mostly missing prototypes.
> Also enclosed is one real patch to putw/setw, which has a missing
> argument in the prototype.
> 
> Cheers,
> edward.
> 
> Summary:
> 
> newlib/libc/include/grp.h        : initgroups   <- yes it's a stub, but
> it's nice to have the prototype
> newlib/libc/include/stdio.h      : getw
> newlib/libc/include/stdio.h      : putw
> newlib/libc/include/string.h     : memccpy
> newlib/libc/include/sys/signal.h : killpg
> newlib/libc/include/sys/stat.h   : mknod                <- yes it's a stub, but it's
> nice to have the prototype
> newlib/libc/include/sys/unistd.h : getpgid
> newlib/libc/include/sys/unistd.h : setpgrp
> newlib/libc/include/sys/unistd.h : vhangup
> 
> ChangeLog:
> 
> Mon Feb  7 02:57:33 2001  Edward M. Lee  <tailbert AT yahoo DOT com>
> 
>         * libc/include/grp.h: add prototype for initgroups
>         * libc/include/stdio.h: fix prototype for putw; remove duplicate
> prototypes of getw/putw
>         * libc/include/string.h: add prototype for memccpy
>         * libc/include/sys/signal.h: add prototype for killpg
>         * libc/include/sys/stat.h: enable mknod/lstat for CYGWIN
>         * libc/include/sys/unistd.h: add prototypes for getpgid, setpgrp,
> vhangup
> 
> __________________________________________________

Edward,

  The patch has been checked in with some modifications.  First of all, memccpy is
already in string.h.  Your putw change added a variable name "w" which we 
avoid so it was reverted.  There were no duplicate prototypes for getw and putw.  
Adding a prototype for mknod breaks Cygwin since it doesn't match the empty prototype
in syscalls.cc.  When syscalls.cc changes, the mknod prototype can be added back.  
The killpg() function prototype has been changed to match the Single Unix specification.  The Cygwin
developers here have changed it in the online sources so it matches.  The final change was to note
that
you removed a duplicate prototype for sysconf.

-- Jeff J.

--
Want to unsubscribe from this list?
Check out: http://cygwin.com/ml/#unsubscribe-simple