Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <3A2F6724.8808AEE5@redhat.com>
Date: Thu, 07 Dec 2000 11:32:04 +0100
From: Corinna Vinschen <vinschen AT redhat DOT com>
Reply-To: cygwin AT cygwin DOT com
X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.14-SMP i686)
X-Accept-Language: de, en
MIME-Version: 1.0
To: cygwin <cygwin AT cygwin DOT com>
Subject: Re: [patch] default homedir (was: Re: Problem withssh-keygen.exe.
References: <Pine DOT SOL DOT 3 DOT 91 DOT 1001205145615 DOT 26082A-100000 AT cse DOT cygnus DOT com>
	 <5 DOT 0 DOT 0 DOT 25 DOT 0 DOT 20001205233111 DOT 027a5eb0 AT pop DOT bresnanlink DOT net> <5 DOT 0 DOT 0 DOT 25 DOT 0 DOT 20001206202732 DOT 02a2f640 AT pop DOT bresnanlink DOT net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Chris Abbey wrote:
> >    if (strlen(foo) == 0)
> 
> It's habit forming to do it the otherway, I'll make a mental
> note to use the dangerous form for cygwin patches.

Personally I like   if (!strlen (foo))   much more.

I have applied your patch but I have changed this and that:

- You have used `passed_home_path' uninitialized which resulted in
  garbage in the output on my system when the `-p' option wasn't
  given.

- We are following the GNU coding convention in that a space should be
  placed between a function name and the following paren and that the
  braces should be placed

	if ()
	  {
	    cmds;
	  }

  instead of

	if () {
	  cmds;
	}

- I have changed the `if (strlen (foo) == 0) conditionals to
  `if (foo[0] == '\0')' which I personally prefer when checking
  for len == 0.

While incorporating your patch I found a typo in the longopts
structure. I had once written "loca-group" instead of "local-group".
I have fixed this in the same go.

Thanks for contributing that patch,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.
mailto:vinschen AT redhat DOT com

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com