Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Wed, 8 Nov 2000 21:02:48 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin AT sources DOT redhat DOT com
Subject: Re: PATCH: (sort of) RE: Possible bug with select and master side of pty
Message-ID: <20001108210248.A3503@redhat.com>
Reply-To: cygwin AT sources DOT redhat DOT com
Mail-Followup-To: cygwin AT sources DOT redhat DOT com
References: <20001108110537 DOT I17097 AT redhat DOT com> <001a01c049b6$07993310$21c9ca95 AT mow DOT siemens DOT ru> <20001108210126 DOT A3325 AT redhat DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.6i
In-Reply-To: <20001108210126.A3325@redhat.com>; from cgf@redhat.com on Wed, Nov 08, 2000 at 09:01:26PM -0500

On Wed, Nov 08, 2000 at 09:01:26PM -0500, Christopher Faylor wrote:
>Could you test out the patch below and let me know if it works for you?

It would be nice for me to include the patch when I suggest stuff like this.

cgf

Wed Nov  8 21:00:31 2000  Christopher Faylor <cgf AT cygnus DOT com>

        * select.cc (peek_pipe): Deal with pending newline in pty_master.

Index: select.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/select.cc,v
retrieving revision 1.27
diff -u -p -r1.27 select.cc
--- select.cc	2000/09/08 03:12:13	1.27
+++ select.cc	2000/11/09 01:57:26
@@ -418,12 +418,23 @@ peek_pipe (select_record *s, int ignra)
 	  goto out;
 	}
 
-      if (!ignra && fh->get_device () != FH_PTYM && fh->get_device () != FH_TTYM &&
-	  fh->get_readahead_valid ())
+      switch (fh->get_device ())
 	{
-	  select_printf ("readahead");
-	  gotone = s->read_ready = 1;
-	  goto out;
+	case FH_PTYM:
+	case FH_TTYM:
+	  if (((fhandler_pty_master *)fh)->need_nl)
+	    {
+	      gotone = s->read_ready = 1;
+	      goto out;
+	    }
+	  break;
+	default:
+	  if (!ignra && fh->get_readahead_valid ())
+	    {
+	      select_printf ("readahead");
+	      gotone = s->read_ready = 1;
+	      goto out;
+	    }
 	}
     }
 

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com