Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Message-ID: <F10D23B02E54D011A0AB0020AF9CEFE988F974@lynx.ceddec.com>
From: "Town, Brad" <btown AT ceddec DOT com>
To: "'cygwin AT sources DOT redhat DOT com'" <cygwin AT sources DOT redhat DOT com>
Subject: RE: Make --win32 shell bug?
Date: Wed, 18 Oct 2000 17:50:22 -0400
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2650.21)
Content-Type: multipart/mixed;
	boundary="----_=_NextPart_000_01C0394D.6A74ABF0"

------_=_NextPart_000_01C0394D.6A74ABF0
Content-Type: text/plain

Attached are two patches to avoid the stackdump with make-3.79.1-1 and the
Makefile I was using to test them.

The patch to job.c fixes the access violation; the patch to function.c fixes
a tiny bug when nothing is read into the buffer but later code assumes it's
a null-terminated string.

Note that it still doesn't work 100%:

make: cmd.exe: Command not found
make: Nothing to be done for `all'.

Anyone else want to help?

Brad Town


> On Wed, Oct 18, 2000 at 08:55:27AM +0200, Axel Kittenberger wrote:
> >Hi,
> >
> >the
> >-----------------------------------------
> >OBJLST := $(shell echo hello)
> >-----------------------------------------
> >was originally one line, only out of some reason my mailer 
> thought it's
> >better to devide it ;) (hope this time it work's)
> >
> >yes i was running make 3.79-3, since the version number felt somehow
> >"higher", however i downloaded now 3.79.1-1, but the stack 
> error remains the
> >same....
> >
> >Well running in the bash shell invoking make without --win32 works
> >correctly, but starting it from a DOS-BOX with --win32 
> yields me to that stack dump
> >:(
> 
> Oops.  Today I *can* duplicate it.  I must not have been 
> adding --win32
> yesterday.
> 
> Anyway, if you would like to submit a patch to fix this behavior, I'll
> release a new version of make.
> 
> cgf


------_=_NextPart_000_01C0394D.6A74ABF0
Content-Type: application/octet-stream;
	name="function.c.diff"
Content-Disposition: attachment;
	filename="function.c.diff"

--- function.c	Sun Jul  9 16:37:50 2000
+++ function.c.mine	Wed Oct 18 17:36:00 2000
@@ -1433,6 +1433,7 @@
 
       maxlen = 200;
       buffer = (char *) xmalloc (maxlen + 1);
+      buffer[0] = 0;
 
       /* Read from the pipe until it gets EOF.  */
       i = 0;

------_=_NextPart_000_01C0394D.6A74ABF0
Content-Type: application/octet-stream;
	name="job.c.diff"
Content-Disposition: attachment;
	filename="job.c.diff"

--- job.c	Sun Jul  9 16:37:50 2000
+++ job.c.mine	Wed Oct 18 17:41:36 2000
@@ -3102,7 +3102,7 @@
       argv = construct_command_argv_internal (converted_line, restp, shell, ifs, batch_filename_ptr);
 
       /* Point restp back into the original command, if appropriate. */
-      if (*restp)
+      if (restp && *restp)
 	{
 	  for (l = line, cl = converted_line; *l != 0 && cl != *restp; cl++, l++)
 	    if (*l == '\\' && l[1] != '\n')

------_=_NextPart_000_01C0394D.6A74ABF0
Content-Type: application/octet-stream;
	name="Makefile"
Content-Disposition: attachment;
	filename="Makefile"

OBJLST := $(shell echo hello)

all :


------_=_NextPart_000_01C0394D.6A74ABF0
Content-Type: text/plain; charset=us-ascii

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com
------_=_NextPart_000_01C0394D.6A74ABF0--