Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Fri, 22 Sep 2000 09:16:23 -0400
From: Jason Tishler <Jason DOT Tishler AT dothill DOT com>
To: Cygwin <cygwin AT sources DOT redhat DOT com>
Subject: cygwin_dll.h Inconsistency (a.k.a Problem #2 Building Cygwin PostgreSQL)
Message-ID: <20000922091623.B1458@DP>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.4i
Organization: Dot Hill Systems Corp.

While building PostgreSQL 7.0.2 on a stock Cygwin 1.1.4, I noticed the
following inconsistency in cygwin/cygwin_dll.h:

// declaration
int WINAPI _cygwin_dll_entry (HANDLE h, DWORD reason, void *ptr);

// definition
int WINAPI _cygwin_dll_entry (HINSTANCE h, DWORD reason, void *ptr)
{
    ...
}

Unless NO_STRICT is defined (which prevents STRICT from automatically
being defined), HINSTANCE will not be a typedef for HANDLE:

// from winnt.h
#ifdef STRICT
#define DECLARE_HANDLE(n) typedef struct n##__{int i;}*n
#else
#define DECLARE_HANDLE(n) typedef HANDLE n
#endif

// from windef.h
DECLARE_HANDLE(HINSTANCE);

Shouldn't the declaration and definition of _cygwin_dll_entry use either
HANDLE or HINSTANCE consistently?

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corporation         Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason DOT Tishler AT dothill DOT com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com