Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-owner AT sources DOT redhat DOT com
Message-ID: <20000910020438.3180.qmail@web2106.mail.yahoo.com>
Date: Sat, 9 Sep 2000 19:04:38 -0700 (PDT)
From: Kevin Lilly <tea41 AT yahoo DOT com>
Subject: Make bug and patch
To: cygwin AT sources DOT redhat DOT com
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="0-1117142618-968551478=:1473"

--0-1117142618-968551478=:1473
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

We recently ran across a small bug in Make 3.79-3 under Cygwin 1.1.4 so
I took a bit of time to track it down and have attached a patch.  I'm
hoping that whoever is responsible for the make package will see this
and can incorporate it into the next release.

Basically, the bug only occurs under DOS type systems which use CRLFs. 
In fact the code which causes the bug is #if defined for
WIN32_OR_CYGWIN or __MSDOS__.  If a line in a Makefile which uses line
continuations ('\' at the end of the line) happens to end at the same
time that the read.c (readline) method needs to realloc its buffer, the
bug pops up, truncates the line and causes the following error:

Makefile:4: *** commands commence before first target.  Stop.

Which looks like a standard mis-formatted Makefile error, but in fact
the Makefile is perfectly formatted.  Anyhow the fix is simple enough
and I've included the appropriate diff and a sample Makefile.

I'm not on the mailing list so you'll have to send any comments to this
address.

Thanks,
Kevin

__________________________________________________
Do You Yahoo!?
Yahoo! Mail - Free email you can access from anywhere!
http://mail.yahoo.com/
--0-1117142618-968551478=:1473
Content-Type: application/x-tar; name="patch.tar.gz"
Content-Transfer-Encoding: base64
Content-Description: patch.tar.gz
Content-Disposition: attachment; filename="patch.tar.gz"

H4sICCjpujkAA3BhdGNoLnRhcgDtVv9r00AU368L7H94oMzW9Lp8aVK7URlU
1EF1sikiCOGaXpqz6V1IrsbB/N99l7SlMmXYsalwH0qbvC93n/feJ7kWjE67
McmpitO9e4LrOGGvB3sA0A/rX9fpOfW9hhe4DnrcIOz5gd8P0d1znXAPnPsi
tI1lqWgBsEenCy54qQqqZPGrODEXshIPQekhQQiBotZAVxZ8tv8+XcIly3Ee
4PnHzuAYZ+M5jmPZtr0K3L+kqokZgNM/DvDjNTGnp0A8t9/rhGDXv24IaNNp
GRcMWvp7skwSVnQAW83oogNJJuO8bYG1koNtCx1WnqDJbkw8wVQmYDgEFw4P
IYfn0CzTtuz9o6fwDngJueRCcTEDpEdBsKrek4opcPWkBJUymLAZF0LHyAQz
cenaWi+FNNWyEGwKk6vanNFSQTJjqoSYZlkX4LWs2Ffk3qRypXcVUuFeMStL
WvDs6sY2SKXmgTVolk3qhmqu97iRog2pzKb6tiHXbfLOkm3CFS3hC+oXmMho
MUPmLRxhqnCxRBasDl21ob3iXDFY6Awax3IpsDxZYBhVOA6pnTk2gWHHtK3O
V5Ws+ZfrfFxXYjnahh15eoR2PRp7WPcLL08s24JHWO6UJRg0bX08e+t70flF
NPr0Cq/bcH298UXRm8sX55dR1F6PH6c5Slk8ByWhZHXf6mHoHuqCUTQZthlJ
Yr0VVymMLsYvT3QclsBnAitfr7Wa7+iiYdrI81nQcQOtz0HQ+QN5rvEdi8PN
eYLyJLfLk+wsT7K7PMnu8iQ7ypPcVZ7kjvIkv5EnuSHP1SBX94CeLeuExvMS
XSnanY1V82jlHtpyIOCdACE69TmG4GXuta2//R7fFW/oHB/FjN3nHrec/66z
Pv/xHwCeI2jx/cA15/9D4BG8x0eIfaOLPGMlVCmPU5jgq28OS3zFFrBAgYDf
7Q+Iv7KMrmYVFwfWgTXGpyw6KyMc2tD1/F4Q9p8NnP/s6vOBtf+49fbDeNzW
NW1VFUajlBZlNJZiFg113MYVaE/t6MY/OcKNI/pXPFvF4TlxjJZTFqcSzhRU
spizqfb8bR0aGBgYGBgYGBgYGBgYGBgYGBgYGBgYGBgYGBjcHT8A2y14KAAo
AAA=


--0-1117142618-968551478=:1473
Content-Type: text/plain; charset=us-ascii

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com
--0-1117142618-968551478=:1473--