Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Fri, 1 Sep 2000 16:48:18 -0400
Message-Id: <200009012048.QAA23916@envy.delorie.com>
From: DJ Delorie <dj AT delorie DOT com>
To: bkeener AT thesoftwaresource DOT com
CC: cygwin AT sources DOT redhat DOT com
In-reply-to: <VA.000004d4.016577bf@thesoftwaresource.com> (message from Brian
	Keener on Fri, 01 Sep 2000 16:37:56 EDT)
Subject: Instructions for submitting patches
References:  <VA DOT 000004d4 DOT 016577bf AT thesoftwaresource DOT com>
Note-from-DJ: This may be spam


[subject changed to make this easier to find in the future]

> Now as soon as I can figure out how to recompile my change,

$ make

Ok, it's not always that easy.  If you've already checked out the
"winsup" module from cvs and built it, typing "make" in the
winsup/cinstall directory rebuilds just setup.  Otherwise, run "make"
in the directory above winsup (yeah, it takes a while).  You'll have a
fully built cygwin also, in case you want to expand your participation
later ;-)

> Then all I'll have to do is submit a changelog and I saw something
> here recently on how to do that so that should be in the archives.

Here's the quick instructions:

Edit all the files, *except* ChangeLog.

Use "cvs diff -p2 > /tmp/foo" to generate the right diffs for us.

Create your mail message, with the patch (/tmp/foo above) included in
the body (don't attach it, it just makes it harder for me to process).

Create a ChangeLog entry and put it above the patch in your email.
Don't produce a diff for the ChangeLog; that file changes the most and
the odds that your patch will apply correctly are pretty slim.  We're
used to pasting in ChangeLog entries manually.

If you want to edit ChangeLog as you go (emacs users would prefer this
if you're used to the changelog-mode bindings), just cut that part out
of the diff and remove the diff decorations from it to make it a
plain-text entry, or cut-n-paste from your ChangeLog file to the mail
message.

Follow the examples in the other ChangeLog entries, and see
http://www.delorie.com/gnu/docs/GNU/standards_32.html

Include "[patch]" in your subject, like this example:

	Subject: [patch] desktop.cc fix for icons

Make sure your mailer will NOT wrap columns or convert tabs to spaces.
If it will, *then* send the files as file attachments.

Send the mail to cygwin-patches AT sources DOT redhat DOT com

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com