DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 6459GONt783169
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB3604BA900C
Subject: Re: open() creates a new file even if it fails with EMFILE
To: cygwin@cygwin.com
References: <4e8b4746-e4e7-e655-a1b5-05bf5ee54a10@t-online.de>
 <9ea723d3-d3d1-414c-97b5-7c822b796a47@maxrnd.com>
Message-ID: <5919bc97-d9b8-d83c-0acf-381421992214@t-online.de>
Date: Tue, 5 May 2026 11:15:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101
 SeaMonkey/2.53.23
MIME-Version: 1.0
In-Reply-To: <9ea723d3-d3d1-414c-97b5-7c822b796a47@maxrnd.com>
Precedence: list
From: Christian Franke via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin@cygwin.com
Cc: Christian Franke <Christian.Franke@t-online.de>
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>
Content-Transfer-Encoding: 8bit

Mark Geisert via Cygwin wrote:
> Hi Christian,
>
> On 5/4/2026 11:39 AM, Christian Franke via Cygwin wrote:
>> Could be reproduced with 3.6.9 and current HEAD.
>>
>> Testcase:
>>
>> ...
>>
>> Looks like the fd is allocated too late.
>
> Thanks for the report and especially for the STC.  It is during 
> fdtable extension that the limit is checked; by then NtCreateFile() 
> has already been called successfully.  We need to consider a fix that 
> avoids needlessly creating a file that can't be operated on anyway.

You're welcome. I will add an enhanced version of the STC to the 
cygwin-apps/stc repo. Problem was detected by 'stress-ng --open ...' 
with stress-ng 0.21.01-1.

-- 
Regards,
Christian


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple