DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 612Dn4Ga3170166
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A6554BA903E
MIME-Version: 1.0
References: <CAAvCNcDzoq3skCwRuYa2LLTTA3xsnK+eDLB8_SegJZinatMUSg@mail.gmail.com>
 <fc1bdd5b-7732-4430-a130-70ef662acd36@dronecode.org.uk>
 <CAAvCNcAAoJeX470QBp9x+A=zSupb_5TpVDeqnbsJS9dtd-oXQg@mail.gmail.com>
 <aYCpYYE1scT7bdaA@calimero.vinschen.de>
In-Reply-To: <aYCpYYE1scT7bdaA@calimero.vinschen.de>
Date: Mon, 2 Feb 2026 14:47:34 +0100
Message-ID: <CAAvCNcASN+pduqG1LT6S1nZhd02-7vFdj5WNNpgkDbrMgV2ZxQ@mail.gmail.com>
Subject: Re: git fsck complains about error:
 refs/tags/.cyg000000000559e25517156b51cf219f51/libgcj-2.95.0:
 badRefName: invalid refname format?!
To: cygwin@cygwin.com
From: Dan Shelton via Cygwin <cygwin@cygwin.com>
Reply-To: Dan Shelton <dan.f.shelton@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>

On Mon, 2 Feb 2026 at 14:40, Corinna Vinschen via Cygwin
<cygwin@cygwin.com> wrote:
>
> On Feb  2 13:24, Dan Shelton via Cygwin wrote:
> > I'm not sure whether the Cygwin code is correct. I did a peek with a
> > kernel debugger, and I see that FILE_RENAME_INFORMATION.RootDirectory
> > is always NULL if a file gets renamed to .cyg000000000xxxx. But if I
> > try that with NTFS or SMB, the NtSetInformationFile() to set
> > FileRenameInformation always fails.
>
> Your testcase is incorrect, unfortunately.
>
> >     fri->FileNameLength = (wcslen(dstfile)+1)*sizeof(wchar_t);
>
> For NT file paths, never count the trailing \0 to the length:
>
>       fri->FileNameLength = wcslen(dstfile) * sizeof (WCHAR);
>
> With that, your testcase works fine for me.
>
> On which filesystem did you see the problem?

Windows NFSv3 client (the builtin one, not the newer NFSv4.1 one).

Dan
-- 
Dan Shelton - Cluster Specialist Win/Lin/Bsd

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple