DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 55HBIGFM364936
Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 55HBIGFM364936
Authentication-Results: delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=uPBl/hVn
X-Recipient: archive-cygwin@delorie.com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E2C8395B419
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1750159094;
	bh=CBT/45S/eBOEoAwXqucDn3q4FngOAbDvC5oWiY3FKbk=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=uPBl/hVnu+rNE1Lbp15WqjuSQHThAmC8zSxkDQ2kvfFhWprHyxt45TsizDrWlW6kF
	 Z+NDH5hBQjUIFz1YIb0e8EobaZlSK64iveZDRxpdoRh7kymr5Xv8unQ7KTjmOkrVid
	 beuR44/Iz8ps9jf5RA+joGjdSwZSfO381bFOJnvo=
X-Original-To: cygwin@cygwin.com
Delivered-To: cygwin@cygwin.com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D3A3638290BF
Date: Tue, 17 Jun 2025 13:15:51 +0200
To: cygwin-patches@cygwin.com, cygwin@cygwin.com
Subject: Re: [PATCH][API-CONFORMAANCE] Increase SYMLOOP_MAX to 63
Message-ID: <aFFOZ0-JHbJKs1Fc@calimero.vinschen.de>
Mail-Followup-To: cygwin-patches@cygwin.com, cygwin@cygwin.com
References: <CAHnbEG+-vkWb3F9HJFNdtMt1wAtm90kz81p8H=0Y7QrGHn50ag@mail.gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <CAHnbEG+-vkWb3F9HJFNdtMt1wAtm90kz81p8H=0Y7QrGHn50ag@mail.gmail.com>
X-BeenThere: cygwin@cygwin.com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=subscribe>
From: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin-patches@cygwin.com
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces~archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>

Hi Sebastian,

On Jun 17 09:48, Sebastian Feld wrote:
> The following patch increases from 10 to 63, per Windows spec
> https://learn.microsoft.com/en-us/windows/win32/fileio/reparse-points
> 
> Security impact is minor, SYMLOOP_MAX is just an artificial limiter to
> prevent endless loops.

In case of Cygwin (Cygwin is slow, we all know that), the rather low
SYMLOOP_MAX was chosen so the path handling didn't get even slower in
some circumstances I don't remember anymore.  Maybe the times when this
was relevant are over, so we can try this.

However, please send a real git patch created with `git format-patch'
and don't forget your Signed-off-by:".


Thanks,
Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple