DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 535FswH6388808
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F4413858294
Date: Sat, 5 Apr 2025 08:53:55 -0700 (PDT)
To: Jon Turney <jon.turney@dronecode.org.uk>
cc: cygwin@cygwin.com
Subject: Re: dladdr and dll refcount
In-Reply-To: <15190784-9033-46f6-b8d5-1136283958fe@dronecode.org.uk>
Message-ID: <21539ea0-3742-ff54-76dd-0f2bf495364d@jdrake.com>
References: <2ace5ff8-29a2-06a4-6c24-668439d4eb08@jdrake.com>
 <15190784-9033-46f6-b8d5-1136283958fe@dronecode.org.uk>
MIME-Version: 1.0
Precedence: list
From: Jeremy Drake via Cygwin <cygwin@cygwin.com>
Reply-To: Jeremy Drake <cygwin@jdrake.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces~archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>

On Sat, 5 Apr 2025, Jon Turney wrote:

> On 05/04/2025 06:28, Jeremy Drake via Cygwin wrote:
> > I just happened to look at dlfcn.cc dladdr function, and I had a question.
> > Should dladdr be using the GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT
> > flag?  It doesn't seem like dladdr should be incrementing the refcount.
>
> Indeed. Well spotted.
>
> This looks like my mistake back in commit
> c8432a01c8401c121940c806a9d868c4adc4cefd
>
> Assuming that flag is available on all applicable Windows versions, it
> certainly looks like we should be using it (otherwise, I guess we just
> immediately free the handle).

This function (and flag) go back to XP.  (I remember this because I was
irked about not being able to use it, the company I worked for was
supporting old windows versions well past their sell-by date).  I'll send
a patch.

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple