DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 535DqiZX344552
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24681385841E
Message-ID: <15190784-9033-46f6-b8d5-1136283958fe@dronecode.org.uk>
Date: Sat, 5 Apr 2025 14:51:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: dladdr and dll refcount
To: Jeremy Drake <cygwin@jdrake.com>
References: <2ace5ff8-29a2-06a4-6c24-668439d4eb08@jdrake.com>
Content-Language: en-US
Cc: cygwin@cygwin.com
In-Reply-To: <2ace5ff8-29a2-06a4-6c24-668439d4eb08@jdrake.com>
Precedence: list
From: Jon Turney via Cygwin <cygwin@cygwin.com>
Reply-To: Jon Turney <jon.turney@dronecode.org.uk>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>

On 05/04/2025 06:28, Jeremy Drake via Cygwin wrote:
> I just happened to look at dlfcn.cc dladdr function, and I had a question.
> Should dladdr be using the GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT
> flag?  It doesn't seem like dladdr should be incrementing the refcount.

Indeed. Well spotted.

This looks like my mistake back in commit 
c8432a01c8401c121940c806a9d868c4adc4cefd

Assuming that flag is available on all applicable Windows versions, it 
certainly looks like we should be using it (otherwise, I guess we just 
immediately free the handle).


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple