DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 51IJU83x3593975
Date: Tue, 18 Feb 2025 20:29:41 +0100
To: cygwin@cygwin.com
Subject: Re: [regression-3.6] df -k on Cygwin 3.6 no longer lists all
 filesystems
Message-ID: <Z7TfpSKvHtBxPd9f@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <CALXu0UfOeEOsp4=zEa3Q3-9GjCmcQC6RCwdy2QEFA2uVvqRLhg@mail.gmail.com>
 <e8ab61d0-9893-6c20-e234-f58355d30189@jdrake.com>
 <Z7TZkWITTUxxnhf8@calimero.vinschen.de>
 <328ed80b-aadb-262b-fd7b-37d0cc04c88e@jdrake.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <328ed80b-aadb-262b-fd7b-37d0cc04c88e@jdrake.com>
Precedence: list
From: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin@cygwin.com
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces~archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>

On Feb 18 11:19, Jeremy Drake via Cygwin wrote:
> On Tue, 18 Feb 2025, Corinna Vinschen via Cygwin wrote:
> 
> > Yep. Are you going to create a patch?
> 
> I'm not seeing a particularly clean way to do this.  Bring back
> available_drives, mask off bits when we see the corresponding drive root
> from dos_drive_mappings, and return those drive letters whose bits are
> still set at the end?

No, I wouldn't do that.

IMHO, the cleanest way to bring this back is to extend
dos_drive_mappings::dos_drive_mappings():

- Prior to the FindFirstVolumeW/FindNextVolumeW loop, prepend another
  loop iterating over GetLogicalDrives() or GetLogicalDriveStringsW().
  In the loop, call QueryDosDevice and add this info to
  dos_drive_mappings, just as in the FindVolume loop.

- In the second loop, simply ignore all mounts mounted to just a drive
  letter (because the first loop already added them all).

Makes sense?

Corinna


> 
> 
> -- 
> Problem reports:      https://cygwin.com/problems.html
> FAQ:                  https://cygwin.com/faq/
> Documentation:        https://cygwin.com/docs.html
> Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple