DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 50DEbJ712859778
Date: Mon, 13 Jan 2025 15:36:19 +0100
To: cygwin@cygwin.com
Subject: Re: Cygwin main function: vulnerable to wchar_t to char conversion
 attacks or not?
Message-ID: <Z4Uk45VxvMaUfTWX@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <2bc465c57c4826ff6eebbd566a92346e@kylheku.com>
 <176904400.20250110103307@yandex.ru>
 <f1aa49a0-35c0-4df6-997e-33de5517adbc@gmail.com>
 <58ddf2002fe1e33993102592eeb0c506@kylheku.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <58ddf2002fe1e33993102592eeb0c506@kylheku.com>
Precedence: list
From: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin@cygwin.com
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces~archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>

On Jan 10 13:52, Kaz Kylheku via Cygwin wrote:
> On 2025-01-09 23:52, Marco Atzeri wrote:
> > On 10/01/2025 08:33, Andrey Repin via Cygwin wrote:
> >> Greetings, Kaz Kylheku!
> >>
> >>> Hi all,
> >>
> >>> I'm reading an article on attacks that are evidently possible against some Windows
> >>> programs in the area of command line parsing. See below.
> >>
> >>> Does the Cygwin run-time rely on GetCommandLineA to get the char-based command
> >>> line that is parsed into argv[]?
> >>
> >> You can answer this question yourself. The code is open.
> > 
> > Specifically on https://cygwin.com/git/newlib-cygwin.git
> > 
> > /pub/Cygwin/git/newlib-cygwin
> > $ grep -rH GetCommandLineA .
> > ./winsup/CVSChangeLogs.old/cygwin/ChangeLog-2013: (cygwin_GetCommandLineA): Ditto.
> > ./winsup/cygwin/cygwin.din:GetCommandLineA@0 = cygwin_GetCommandLineA@0 NOSIGFE
> > ./winsup/cygwin/include/cygwin/version.h:  268: Export GetCommandLineA, GetCommandLineW
> > ./winsup/cygwin/kernel32.cc:/* Cygwin replacement for GetCommandLineA. Returns a concatenated string
> > ./winsup/cygwin/kernel32.cc:cygwin_GetCommandLineA (void)
> 
> I see that the kernel32.cc function uses RtlUnicodeStringtoAnsiString.
> 
> The article I linked to mentions this specific function. The function does the
> "BestFit" thing, converting Unicode characters to ASCII pseudo-equivalents.
> 
> If Cygwin relies on this function for converting the process command line
> into main() arguments, it is likely susceptible to argument injection.

Yeah, but it doesn't.  This is just a wrapper function for external
apps.  See function dll_crt0_1() in dcrt0.cc for the real deal.


Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple