DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2F12386100A
Message-ID: <5b270642-996d-43b5-bbee-90157321a1a4@johannesthoma.com>
Date: Wed, 3 Jul 2024 16:16:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: cygwin application hangs on closing console
To: Takashi Yano <takashi.yano@nifty.ne.jp>, cygwin@cygwin.com
References: <d268ca90-3c5b-4de6-9dd5-320ee713283c@johannesthoma.com>
 <20240423035104.85352f8a8d821c0f4d569d18@nifty.ne.jp>
 <b71816f0-633c-4eaf-b9d6-955b10e4866a@johannesthoma.com>
 <20240423192606.7b4aa04685afca2525eb5ed3@nifty.ne.jp>
 <6dd8a568-88c0-42d5-aa46-b09247cdecec@johannesthoma.com>
 <b67fc4f5-3fbb-454a-a0ce-da4f987924dc@johannesthoma.com>
 <d00f900a-e70c-4a2b-9570-0d3c9fcd45d2@SystematicSW.ab.ca>
 <5ed3b0b8-d4f8-454c-951a-fc7b85a7c302@johannesthoma.com>
 <95442cfe-a87c-4816-b337-b130e481e3f1@johannesthoma.com>
 <20240628211726.c131e0a300046d1fa46f6b53@nifty.ne.jp>
 <20240629003209.d0bd3cc2961891fb69b55b35@nifty.ne.jp>
 <fb960e5d-ccdd-474b-a046-5178563d4200@johannesthoma.com>
 <20240701222020.bf102502bb184e4b30f1c52b@nifty.ne.jp>
 <20240702194515.01a1e2cf1f2378b412ad3712@nifty.ne.jp>
 <20240703230916.05196d9fa263da9b2ec18f54@nifty.ne.jp>
In-Reply-To: <20240703230916.05196d9fa263da9b2ec18f54@nifty.ne.jp>
UI-OutboundReport: notjunk:1;M01:P0:5K8HLrD2ijQ=;M6ctYOTPeJhsg4SNWkbWBDyugmG
 MMiEYwpklu7Xjiklxm1LlFYioyOuqMTcyZ76HNZc9h9WwR4BHWPMxPYt5MGGRI3FYrDnROz+f
 E+XyDF1VtU2pqMlhzPADpyTJSusG982eiyPu8VVUCtFti1mHh9o4VLmgkpQYHssZff73e1E3D
 CpoMkh465VmEhL3rfORzmyU5yUW2mpd6N9lwsx2PS0ixeIQRoJS0qCNHTR0wVT+RXVmxHZa3u
 C/2JW+P63+82N30gwltmKkmHFUM+P7CCPTAhJSObITAC+Sls8TK8l2FKFlIlOEAzRSq61dB6M
 qYh4wmJw7OQWtc3sN5YUhR4Goff5uchR0sh1SaH1MBvX1ffxC/WMpIoJKMUotXzG5hmpYUZFh
 nHvO5XBy6Jli3WQNy3Z1xtV3no2Stga2Y0xVRXA95IFPUf8BxGrY1GKXtcsz/B7feCl0IzJKN
 h0P7JI7b4KMmWY7+3epT/GkGwJXjM33QjwzaExihKD9popBfolmuBWLJlqRtf1LBNOjrH0DVw
 yHnioKjwIMzzW3gUAYp9sbOTCeaP3/8iqlKtdHVLFQs2iNk7lD6ESFDfapDwiaF+62S/b67L6
 vdJWpQbncYcufN5nZGKlYGgaybBbksKndtbFONU4ogh8LgdjZd7RCU6pERBbIOWkVYZLNmwF6
 rJr4+b79htth43yiFRG21bzWdgqvhoT8YUl/wbpE+OdJ6xE+9DDL7GNVB56U+3sSbzh6xVnhc
 ZXbdfwq5zQmOYc8XAC/rzDR5XjH3BCNSvGLFOCHtC5eI103O+I1f9o=
From: Johannes Khoshnazar-Thoma via Cygwin <cygwin@cygwin.com>
Reply-To: Johannes Khoshnazar-Thoma <johannes@johannesthoma.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie.com@cygwin.com>

Hi Takashi Yano,

Am 03.07.24 um 16:09 schrieb Takashi Yano:
> On Tue, 2 Jul 2024 19:45:15 +0900
> Takashi Yano wrote:
>> On Mon, 1 Jul 2024 22:20:20 +0900
>> Takashi Yano wrote:
>>> On Mon, 1 Jul 2024 13:47:56 +0200
>>> Johannes Khoshnazar-Thoma wrote:
>>>> Note that the hang does not happen when just running cygwin
>>>> applications via terminal windows (like cmd, powershell and
>>>> MinTTY). It triggers however when a cygwin application is
>>>> run both as a service (I think as SYSTEM account, but I
>>>> can ask again) and from a terminal window.
>>>
>>> Service process usually does not have console. So I think
>>> fhandler_console::open()/close() are not called.
>>>
>>> Do you allocate console for your service process somehow?
>>
>> I could reproduce your problem by allocating console for
>> service process.
>>
>> I'll look into the problem. Thanks.
>
> The cause has been clear. As a result, your points and patches
> were very spot on.
>
> get_minor() retuns unique number for each console in a session,
> but not unique accross sessions. I looked over that point.
>
> This is because EnumWindows(), which is used to look for console
> windows, cannot enumerate windows accross sessions. This causes
> conflict on shared name between sessions (e.g. sessions of different
> users, different services, a service and a user session, etc.).
>
> I'll use GetConsoleWindow() instead of get_minor() to create
> shared name.
>
> Thank you very much for finding this problem.
> I'll submit a patch for that and push it shortly.
>
Thank you very much that is awesome news. I will build and
forward a package to our client to verify that this issue
is fixed now as soon as the patch is pushed.

Thanks again for your hard work on cygwin, it is hard to find
bugs in there because there are not that many ... :)

Best regards,

- Johannes

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple