DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66451388982B
Date: Sun, 2 Jun 2024 06:11:26 +0900
To: cygwin@cygwin.com
Cc: Bruno Haible <bruno@clisp.org>
Subject: Re: [PATCH v2] Cygwin: pthread: Fix a race issue introduced by the
 commit 2c5433e5da82
Message-Id: <20240602061126.ecd712bdefb5e6cf5b00674e@nifty.ne.jp>
In-Reply-To: <8f6e5346-52ff-4682-ae9b-de345399b28c@cornell.edu>
References: <20240530050538.53724-1-takashi.yano@nifty.ne.jp>
 <20240530205012.2aff4d507acac144e50df2a4@nifty.ne.jp>
 <20240530205918.7c730117b567bb3bec3a0c3f@nifty.ne.jp>
 <4338587.3DMzsUbDvx@nimes>
 <20240601231830.882dc56aadb9c3087bcf4b9c@nifty.ne.jp>
 <8f6e5346-52ff-4682-ae9b-de345399b28c@cornell.edu>
Mime-Version: 1.0
Precedence: list
From: Takashi Yano via Cygwin <cygwin@cygwin.com>
Reply-To: Takashi Yano <takashi.yano@nifty.ne.jp>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Sat, 1 Jun 2024 12:08:51 -0400
Ken Brown wrote:
> Hi Takashi,
> 
> On 6/1/2024 10:18 AM, Takashi Yano via Cygwin wrote:
> > int
> > pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
> > {
> >    /* Sign bit of once_control->state is used as done flag.
> >       Similary, the next significant bit is used as destroyed flag. */
> 
>          Typo: Similarly
> 
> >    const int done = INT_MIN;		/* 0b1000000000000000 */
> >    const int destroyed = INT_MIN >> 1;	/* 0b1100000000000000 */
> 
> Shouldn't the constants in the comments have 32 bits?  Other than that, 
> LGTM.  (But you should wait for Bruno to confirm before you commit.)

Thanks for checking!

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple