DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13F413858C32
Message-ID: <72594c25-f142-42f0-b4cd-e2650e8044db@maxrnd.com>
Date: Tue, 2 Apr 2024 01:57:19 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: util-linux-2.39.3-1: libblkid returns invalid physical_sector_size
To: cygwin@cygwin.com
References: <0fb74540-3878-206d-b623-15437fe79b01@t-online.de>
Content-Language: en-US
In-Reply-To: <0fb74540-3878-206d-b623-15437fe79b01@t-online.de>
Precedence: list
From: Mark Geisert via Cygwin <cygwin@cygwin.com>
Reply-To: Mark Geisert <mark@maxrnd.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

Hi Christian,

On 3/31/2024 1:11 AM, Christian Franke via Cygwin wrote:
> Testcase:
> 
> # cygcheck -f /sbin/fdisk.exe
> util-linux-2.39.3-1
> 
> # /sbin/fdisk.exe -l /dev/sdd
> Disk /dev/sdd: 465.76 GiB, 500107862016 bytes, 976773168 sectors
> Units: sectors of 1 * 512 = 512 bytes
> Sector size (logical/physical): 512 bytes / 34359738880 bytes
> I/O size (minimum/optimal): 34359738880 bytes / 34359738880 bytes
[...valuable investigation and patch suggestion elided...]

Your suggested patch looks fine to me.  I have added it to the patch 
deck for a new util-linux 2.39.3-2, which has just been uploaded.  The 
patch allows fdisk.exe to report the three correct values in my limited 
testing.
Thanks for the report and the patch!

..mark


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple