DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA2223858D37
Date: Mon, 18 Mar 2024 13:58:26 +0900
To: cygwin@cygwin.com
Subject: Re: Bogus exit code 127 from a child process
Message-Id: <20240318135826.e4176868074e074eb3138cb5@nifty.ne.jp>
In-Reply-To: <20240318120906.ccac3ad237a8f6c4c1b94c71@nifty.ne.jp>
References: <d5c90ec69060cea65c9eb31492a655ac@ispras.ru>
 <20240317174402.4a3e73a7fca2f5978ac93913@nifty.ne.jp>
 <61d4fca73047915567fc9b4aac2860a3@ispras.ru>
 <20240317182757.84b41a596c344f395c1d8f9a@nifty.ne.jp>
 <c587acce90e624992471b392c1f0e171@ispras.ru>
 <20240317192116.b00f24c9ee065f16d6ac6673@nifty.ne.jp>
 <20240317210358.ad701873dc5cfc9a3026dc0c@nifty.ne.jp>
 <20240317211517.40cfbe0a664f7c7fe3d6e73d@nifty.ne.jp>
 <20240317213548.652be777a51f00108414d9bf@nifty.ne.jp>
 <8F45EC6F-A035-449B-89D0-065FAE3FC157@unified-streaming.com>
 <259F0ECF-9AE8-42E7-A746-8227F8B7870C@unified-streaming.com>
 <20240318120906.ccac3ad237a8f6c4c1b94c71@nifty.ne.jp>
Mime-Version: 1.0
Precedence: list
From: Takashi Yano via Cygwin <cygwin@cygwin.com>
Reply-To: Takashi Yano <takashi.yano@nifty.ne.jp>
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Mon, 18 Mar 2024 12:09:06 +0900
Takashi Yano wrote:
> On Sun, 17 Mar 2024 14:10:55 +0100
> Dimitry Andric wrote:
> > On 17 Mar 2024, at 13:50, Dimitry Andric <dimitry@unified-streaming.com> wrote:
> > > 
> > > On 17 Mar 2024, at 13:35, Takashi Yano via Cygwin <cygwin@cygwin.com> wrote:
> > > ...
> > >> 
> > >> I also test your test case:
> > >> while bash -c 'true & true & wait -n || { echo 1: $?; exit 1; } && wait -n || { echo 2: $?; exit 1; }'; do echo $((i++)); done
> > >> in Linux (Debian 12.5), and the issue reproduced!
> > > 
> > > Yeah, same here with bash 5.1.16(1)-release on Ubuntu 22.04. It errors out with 127 after ~50-200 loops.
> > 
> > Having built bash master (bash-5.2-27-gf3b6bd19) here, it consistently gives 127 in this area:
> > 
> > https://git.savannah.gnu.org/cgit/bash.git/tree/builtins/wait.def#n227
> > 
> >    211  #if defined (JOB_CONTROL)
> >    212    if (nflag)
> >    213      {
> >    214        if (list)
> >    215          {
> >    216            opt = set_waitlist (list);
> >    217            if (opt == 0)
> >    218              WAIT_RETURN (127);
> >    219            wflags |= JWAIT_WAITING;
> >    220          }
> >    221
> >    222        status = wait_for_any_job (wflags, &pstat);
> >    223        if (vname && status >= 0)
> >    224          builtin_bind_var_to_int (vname, pstat.pid, bindflags);
> >    225
> >    226        if (status < 0)
> > => 227          status = 127;
> >    228        if (list)
> >    229          unset_waitlist ();
> >    230        WAIT_RETURN (status);
> >    231      }
> >    232  #endif
> > 
> > So for some reason, wait_for_any_job() returns a negative value in this particular situation.
> 
> Line 218 looks also suspicious.

Probably, this is not a bug. man bash says:
              If  the  -n option is supplied, wait waits for a single job from
              the list of ids or, if no ids are supplied, any job, to complete
              and returns its exit status.  If none of the supplied  arguments
              is a child of the shell, or if no arguments are supplied and the
              shell  has no unwaited‐for children, the exit status is 127.

If the background process exited before calling 'wait -n', it returns 127.
This is very different from wait() system call, which is necessary for
any background joubs, otherwise zombie remains.

In the shell, it is not necessary to call wait command for background jobs,
therefore exit status of the background job which already exited is not held
anymore.

So, actual bug is in the test case.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple