DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F0A83858C55
Message-ID: <53386f98-f5f9-42d4-8a35-4000103bec7b@dronecode.org.uk>
Date: Sun, 3 Mar 2024 16:23:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Setup 2.930: 'user_picked' flag not set for packages selected
 with -P option
Content-Language: en-US
To: Christian Franke via Cygwin <cygwin@cygwin.com>
References: <36f81861-b822-32d0-6a2a-92c8c710ff24@t-online.de>
Cc: cygwin@cygwin.com
In-Reply-To: <36f81861-b822-32d0-6a2a-92c8c710ff24@t-online.de>
Precedence: list
From: Jon Turney via Cygwin <cygwin@cygwin.com>
Reply-To: Jon Turney <jon.turney@dronecode.org.uk>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On 03/03/2024 14:42, Christian Franke via Cygwin wrote:
> Setup 2.930 does not set the 'user_picked' flag in 
> /etc/setup/installed.db if a package has been selected with the -P 
> option instead of the chooser dialog.
> 
> An installation could be replicated by extracting a list of 
> 'user_picked' packages from installed.db and pass it via -P to setup. 
> But in this new installation, all non-Base packages will appear in 
> "Unneeded" view then.
> 
> I guess this is not a regression but longstanding behavior.

Hmm... I certainly envisioned it working that way when I added recording 
user_picked (See comments on [1], [2]), but I can believe it's got 
broken at some point...

[1] 
https://cygwin.com/cgit/cygwin-apps/setup/commit/?id=f6d6c600edffdb83a57ed13384e38a504fdc366b
[2] 
https://cygwin.com/cgit/cygwin-apps/setup/commit/?id=dbd295e75edfadd5fc6feebe11b482cd672575cf

> No patch provided for now as I don't know the best way to change this.

But yes, this is definitely a bug!


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple