Date: Fri, 9 Feb 2024 18:02:23 +0100
To: cygwin@cygwin.com
Subject: Re: Updated: setup (2.930)
Message-ID: <ZcZan_0kb3v_Y-jG@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <6a25c776-98bb-4240-8a57-7081324c5a05@dronecode.org.uk>
 <23db00778577ab0853fe1026befb9fe8@kylheku.com>
 <3391e2e4-da0e-4985-9ec3-a6639f497db9@dronecode.org.uk>
 <ZcZQ5v1Oabbop8XM@calimero.vinschen.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <ZcZQ5v1Oabbop8XM@calimero.vinschen.de>
Precedence: list
From: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin@cygwin.com
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Feb  9 17:20, Corinna Vinschen via Cygwin wrote:
> On Feb  9 13:36, Jon Turney via Cygwin wrote:
> > On 09/02/2024 02:17, Kaz Kylheku via Cygwin wrote:
> > > 
> > > I see the commit: https://cygwin.com/cgit/cygwin-apps/setup/commit/?id=0122154811bacdd7dc042cff0c80bb0a36af360c
> > > 
> > > I'm curious, what improvement arises out of looking up the SetDefaultDllDirectories
> > > function dynamically in kernel32.dll?
> > > 
> > > Is it the case that malicious software can interpose itself somehow such that
> > > the statically linked SetDefaultDllDirectories call goes elsewhere other than
> > > kernel32.dll, which we can thwart by asking for the genuine article in kernel32.dll?
> > 
> > You're looking at the wrong commit there.
> > 
> > The dynamic lookup merely ensures that setup continues to work at all on
> > Windows versions (<6.0), which don't support that function.
> 
> Typo.  Windows < 6.2.  SetDefaultDllDirectories has been introduced with
> Windows 8.

...and with KB2533623 it was also backported to Vista, W7, and the
equivalent server versions, so just ignore me.

Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple