DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F4683858C66
Date: Wed, 3 Jan 2024 08:25:56 +0900
To: cygwin@cygwin.com
Cc: Kaz Kylheku <kaz@kylheku.com>
Subject: Re: Possibly buggy use of ctype.h macros.
Message-Id: <20240103082556.8ba92d98e1023f6e6fb175e2@nifty.ne.jp>
In-Reply-To: <e7301d2e6aef776277cd6d81be0424a8@kylheku.com>
References: <e7301d2e6aef776277cd6d81be0424a8@kylheku.com>
Mime-Version: 1.0
Precedence: list
From: Takashi Yano via Cygwin <cygwin@cygwin.com>
Reply-To: Takashi Yano <takashi.yano@nifty.ne.jp>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Tue, 02 Jan 2024 14:18:15 -0800
Kaz Kylheku via Cygwin <cygwin@cygwin.com> wrote:
> I noticed that this macro, defined in winsup/cygwin/local_includes/path.h: 
> 
>   #define isdrive(s) (isalpha (*(s)) && (s)[1] == ':') 
> 
> is being used with arguments of type char, like dereferenced "char *" pointers. 
> 
> Unless the isalpha implementation is robust against this, it should be isalpha((unsigned char) *(s)).


https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/ctype/ctype_.h;h=a73870b3e4ade5545fd41bcc6f10446a22b4b46e;hb=HEAD

https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=newlib/libc/ctype/ctype_.c;h=32ce4f3187dc528c3103d6d884708d7f364a6698;hb=HEAD#l82

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple