DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58A9E3858D32
Message-ID: <ef3d8337-7b76-4d25-a300-7c13ff54de40@SystematicSW.ab.ca>
Date: Tue, 2 Jan 2024 14:28:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: strverscmp is buggy in newlib 4.4.0 (was: Cygwin 3.4.6)
Content-Language: en-CA
To: newlib@sourceware.org
References: <13421190.uLZWGnKmhe@nimes>
 <1052086998.4232956.1704227350804@mail.yahoo.com>
Organization: Systematic Software
In-Reply-To: <1052086998.4232956.1704227350804@mail.yahoo.com>
Precedence: list
From: Brian Inglis via Cygwin <cygwin@cygwin.com>
Reply-To: newlib@sourceware.org
Cc: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>, cygwin@cygwin.com
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>
Content-Transfer-Encoding: 8bit

On 2024-01-02 13:29, matthew patton via Cygwin wrote:
>> The cause is apparently that Cygwin's strverscmp implementation wasborrowed from musl libc
> would it make sense to use git submodules when "borrowing" code so the
> upstream reference is not lost, and keeping it abreast is relatively trivial
> exercise?
Issue is in newlib (x-post and followups set):
https://sourceware.org/cgit/newlib-cygwin/tree/newlib/libc/string/strverscmp.c

Docs for man pages are embedded in newlib (but not Cygwin unfortunately) 
sources, but it would be nice if folks added a subsection or reference with 
{Free,Open,Net}BSD/musl/etc. links, so we could see where and when the code was 
copied, although some sources include BSD revision headers and copyrights, other 
sources have no identifying header.

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple