DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72DFA3858401
To: cygwin@cygwin.com
Cc: Dmitry Bogatov <KAction@gnu.org>
Subject: strverscmp is buggy in Cygwin 3.4.6
Date: Tue, 02 Jan 2024 11:23:26 +0100
Message-ID: <13421190.uLZWGnKmhe@nimes>
MIME-Version: 1.0
From: Bruno Haible via Cygwin <cygwin@cygwin.com>
Reply-To: Bruno Haible <bruno@clisp.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

Hi,

Here's a test case of strverscmp, from Dmitry Bogatov [1]

#include <string.h>
int main ()
{
  return strverscmp ("UNKNOWN", "2.2.0") <= 0;
}

It succeeds on glibc and musl libc 1.2.4, but fails on musl libc 1.2.3
and Cygwin 2.9.0 and 3.4.6.

The cause is apparently that Cygwin's strverscmp implementation was
borrowed from musl libc (Cygwin commit 59e09b6419cdf400be3c73b61ac9c22560dc397e)
at a time when musl libc's implementation was buggy. In musl libc, it is
meanwhile fixed, through
https://git.musl-libc.org/cgit/musl/commit/src/string/strverscmp.c?id=b50eb8c36c20f967bd0ed70c0b0db38a450886ba

Bruno

[1] https://lists.gnu.org/archive/html/bug-gnulib/2024-01/msg00002.html


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple