DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC19A385735A
Date: Thu, 24 Aug 2023 06:05:02 +0900
To: cygwin@cygwin.com
Subject: scp stalls on uploading in cygwin 3.5 current master.
Message-Id: <20230824060502.c4798062cb19d4d35a5633ae@nifty.ne.jp>
Mime-Version: 1.0
From: Takashi Yano via Cygwin <cygwin@cygwin.com>
Reply-To: Takashi Yano <takashi.yano@nifty.ne.jp>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

Hi Corinna,

After the commit dedbbd74d0a8, "scp file server:." stalls.
I confirmed this when the "server" is a Linux machine.
The problem does not occur if it is reverted.

Could you please have a look?

commit dedbbd74d0a8f3b7dfae6188321703a47bb8a2b3
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Tue Aug 1 14:22:55 2023 +0200

    Cygwin: select: workaround FD_WRITE network event handling
    
    The FD_WRITE event is a false friend.  It indicates ready to write
    even if the next send fails with WSAEWOULDBLOCK.  *After* the fact,
    FD_WRITE will be cleared until sending is again possible, but that
    is too late for a select/write loop.
    
    Workaround that by using the WinSock select function when peeking
    at a socket and FD_WRITE gets indicated. WinSock select fortunately
    indicates writability correctly.
    
    Fixes: 70e476d27be8 ("(peek_socket): Use event handling for peeking socket.")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>


-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple