DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32CCA3858CDA
To: cygwin@cygwin.com
Subject: Re: fnmatch improvements
Date: Fri, 28 Jul 2023 21:33:50 +0200
Message-ID: <7165278.bTWiN4Om4I@nimes>
In-Reply-To: <ZMQP/7EphqiQNUVW@calimero.vinschen.de>
References: <3884636.3uDm00564X@nimes> <24556977.snJFCo28Jb@nimes>
 <ZMQP/7EphqiQNUVW@calimero.vinschen.de>
MIME-Version: 1.0
Precedence: list
From: Bruno Haible via Cygwin <cygwin@cygwin.com>
Reply-To: Bruno Haible <bruno@clisp.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

Corinna Vinschen wrote:
> >   1. cd testdir-fnmatch-posix
> >      ./configure
> >      grep REPLACE_FNMATCH config.status
> >      (Expected: REPLACE_FNMATCH is 0)
> 
>   $ grep REPLACE_FNMATCH config.status
>   S["REPLACE_FNMATCH"]="0"
> 
> >      make
> >      make check
> >      (Expected: No test failures)
> 
>   # TOTAL: 218
>   # PASS:  178
>   # SKIP:  40
>   # XFAIL: 0
>   # FAIL:  0
>   # XPASS: 0
>   # ERROR: 0
> 
>   test-fnmatch-5.sh is SKIPped because we don't support zh_CN.GB18030.
> 
> >      cd ..
> >   2. cd testdir-fnmatch-gnu
> >      ./configure
> >      grep REPLACE_FNMATCH config.status
> >      (Expected: REPLACE_FNMATCH is 1, because of FNM_EXTMATCH)
> 
>   $ grep REPLACE_FNMATCH config.status
>   S["REPLACE_FNMATCH"]="1"
> 
> >      make
> >      make check
> >      (Expected: No test failures)
> 
>   # TOTAL: 218
>   # PASS:  178
>   # SKIP:  40
>   # XFAIL: 0
>   # FAIL:  0
>   # XPASS: 0
>   # ERROR: 0
> 
>   Same SKIP of test-fnmatch-5.sh.
> 
> Does that look ok?

Yes, that's all OK and as expected. I'll commit the fnmatch.m4 patch today.

When the user asks for an fnmatch() with FNM_EXTMATCH support, they will get
the Gnulib fnmatch(), as it supports these GNU extensions. I'll think about
how to make [=X=] and [.X.] work in this case too...

Thank you for your constructive cooperation!

Bruno


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple