Date: Thu, 27 Jul 2023 21:05:49 +0200
To: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Subject: Re: fnmatch improvements
Message-ID: <ZMLADRFGUuvEnCT+@calimero.vinschen.de>
Mail-Followup-To: Corinna Vinschen via Cygwin <cygwin@cygwin.com>,
 Bruno Haible <bruno@clisp.org>
References: <3884636.3uDm00564X@nimes> <ZMK2UVB71pEeoFDK@calimero.vinschen.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <ZMK2UVB71pEeoFDK@calimero.vinschen.de>
Precedence: list
From: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin@cygwin.com
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>,
        Bruno Haible <bruno@clisp.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Jul 27 20:24, Corinna Vinschen via Cygwin wrote:
> On Jul 27 12:15, Bruno Haible via Cygwin wrote:
> I'm looking into that.  First thing, your testsuite uncovered a bug in
> the latest fnmatch in the C locale. Comparing pointers instead of
> comparing characters was never a good idea for pattern matching...
> 
> When I'm done I hope that our 3.5 fnmatch won't be overridden by the
> gnulib version :}
> 
> > I can't easily install a Cygwin 3.5.0 snapshot. If one of you would like to
> > help, here's how to:
> >   1. Create an environment for working with a Cygwin 3.5.0 snapshot (from
> >      March 2023 or newer).
> >   2. wget https://haible.de/bruno/gnu/testdir-fnmatch.tar.gz
> >   3. tar xfz testdir-fnmatch.tar.gz
> >   4. cd testdir-fnmatch-posix
> >      ./configure 2>&1 | tee log1
> >      make
> >      make check

I fixed the above problem and the POSIX check now works fine:

> >      grep fnmatch log1

    checking for fnmatch.h... yes
    checking for fnmatch... yes
    checking for working POSIX fnmatch... yes

I also extraced the fnmatch configure testcase and ran it manually.
It returns 0 now.  But:

> >      grep REPLACE_FNMATCH config.status

    S["REPLACE_FNMATCH"]="1"

Looks like the reason is that we don't have a uchar.h file?  Seems 
like this is of interest for AIX, but why should this be of
interest for fnmatch on other systems?


Thanks,
Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple