DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C80E3858D37
Message-ID: <feddbafb-5e48-1940-0dd3-1aa63e0b1303@dronecode.org.uk>
Date: Sun, 12 Feb 2023 16:35:12 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: Curious setup behavior?
Content-Language: en-GB
To: jhg@acm.org, The Cygwin Mailing List <cygwin@cygwin.com>
References: <19227575-b1f5-e21d-8739-3b2033e8025a@jhmg.net>
In-Reply-To: <19227575-b1f5-e21d-8739-3b2033e8025a@jhmg.net>
From: Jon Turney via Cygwin <cygwin@cygwin.com>
Reply-To: Jon Turney <jon.turney@dronecode.org.uk>
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>
Content-Transfer-Encoding: 8bit

On 02/02/2023 19:46, Jim Garrison via Cygwin wrote:
> 1) Launch setup-x86_64 and go as far as the "Pending" list (assuming
>     there are pending packages to be updated).  Note "Best" is selected.
> 
> 2) Then click "Back" to get to the mirror selection page
> 
> 3) Click "Next" again.
> 
> Now it says there is nothing pending.
> 
> 4) Click back (mirror selection) and re-select the same or a different
>     mirror and click "Next"
> 
> Still nothing pending, "Best" is still selected.
> 
> 5) Select "Sync" instead of "Best"
> 
> All the pending packages reappear.  Switching from "Sync" back to "Best"
> does not affect the display at this point.

Well, it does because these are two different things, but in most usual 
circumstances they select the same set of packages.

(I think e.g. if you've previously installed a test version, they will 
give different results)

> If you initially have "Sync" selected, then switching to "Best" reveals
> the missing pending items.  I.e. restoring the list seems to be
> "edge-triggered" on the "Keep/Best/Sync" state.

Yes, this is almost certainly not implemented correctly.

Unfortunately, this is complex, because of interactions with how we 
apply packages and selection modes selected via the command line. It's 
not clear at all to me what should happen here when those exist and 
you've then modified them in the chooser and then go back and forward.

At the moment, the back button is always enabled, I think.  There's 
probably some points in the flow where we shouldn't allow that.


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple