DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 886B93858CDA
Date: Tue, 10 Jan 2023 19:01:45 +0900
To: cygwin@cygwin.com
Subject: Re: Cygwin 3.4.3 and 3.5.0... hangs in make, top, procps, ls
 /proc/PID/...
Message-Id: <20230110190145.ed5438f6c7a9d979899fa823@nifty.ne.jp>
In-Reply-To: <Y7xLNqMa8zdIkRfj@calimero.vinschen.de>
References: <4a4427cc-422b-1d14-015e-26523e620d9b@Shaw.ca>
 <20230102113201.476c10bef7a5643bddc00762@nifty.ne.jp>
 <Y7xLNqMa8zdIkRfj@calimero.vinschen.de>
Mime-Version: 1.0
Precedence: list
From: Takashi Yano via Cygwin <cygwin@cygwin.com>
Reply-To: Takashi Yano <takashi.yano@nifty.ne.jp>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Mon, 9 Jan 2023 18:13:26 +0100
Corinna Vinschen wrote:
> If q->sigtls is NULL, the signal is nevertheless waiting for being
> handled.  It's just not directed at a specific thread.  Beats me, why
> this didn't occur in my testing.  The process signal info should contain
> the process-wide mask of pending signals as well, obviously, so the
> following patch should do the right thing:
> 
> diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
> index ce36c8be37fb..86e4e607ab7e 100644
> --- a/winsup/cygwin/sigproc.cc
> +++ b/winsup/cygwin/sigproc.cc
> @@ -1375,7 +1375,8 @@ wait_sig (VOID *)
>  	    *pack.mask = 0;
>  	    while ((q = q->next))
>  	      {
> -		if (q->sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo)))
> +		_cygtls *sigtls = q->sigtls ?: _main_tls;
> +		if (sigtls->sigmask & (bit = SIGTOMASK (q->si.si_signo)))
>  		  {
>  		    tl_entry = cygheap->find_tls (q->si.si_signo, issig_wait);
>  		    if (tl_entry)
> 
> Can you confirm?

I confirmed that your patch fixes the issue.

This issue can be easily reproduced in my environment by:
1) Open two mintty windows.
2) Run "while true; do procps; done" in one mintty.
3) Build cygwin1.dll in another window.
Build hangs in a short time and response of procps slows down.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple