X-Recipient: archive-cygwin@delorie.com X-Original-To: cygwin@cygwin.com Delivered-To: cygwin@cygwin.com DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF4CB385841A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dinwoodie.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinwoodie.org Date: Thu, 25 Aug 2022 11:34:45 +0100 From: Adam Dinwoodie To: cygwin@cygwin.com Subject: Re: single key stroke `git add -p` bug Message-ID: <20220825103445.j67sjtwmea4sfkoy@lucy.dinwoodie.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: cygwin@cygwin.com Content-Type: text/plain; charset="iso-8859-1" Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com Sender: "Cygwin" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id 27PAZTcm019635 On Thu, Aug 25, 2022 at 01:17:28AM +0200, trashyankes wrote: > Hello I update recently all cygwin packages and after that `git add > -p` stop working correctly. (previous update I did around 2 month > ago) I use mintty on Windows 10 x64, and have set `git config > --global interactive.singlekey true` when I run this command whole > terminal freeze and show message from git: ``` warning: reading > single keystrokes not supported on this platform; reading line instead > ``` mintty stop accepting any input even `Ctrl-C`. I tried to > revert mintty and git to older version but every one available have > same behavior. For now disabling `singlekey` make this git operation > work again but this is big lose in productivity. Confirmed. I'm not sure what's going wrong here: as I understand it, this function depends on the Term::ReadKey Perl module, provided by the Cygwin perl-TermReadKey package, but that package is correctly listed as both a buildtime and runtime dependency for the git package. I'll add to my queue to do some more debugging, but I'm not expecting to have time to do any serious investigation here for a while. Obviously if anyone else is able to identify the problem, I'm very happy to consider patches! Adam (Cygwin Git maintainer) -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple