DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA62F3858D32
Content-Type: multipart/mixed; boundary="------------NR480x0Z6g56UPsnaMC91Dpt"
Message-ID: <d6be6754-4fad-cd5f-43f9-f4b660be86a0@dronecode.org.uk>
Date: Sun, 14 Aug 2022 20:00:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: setup 2.920 release candidate - please test
Content-Language: en-GB
To: The Cygwin Mailing List <cygwin@cygwin.com>
References: <3d4086be-7800-6e57-30f6-420d71dc70a4@dronecode.org.uk>
 <a55e0852-0ba2-3f9a-bb82-acc1dfca2c16@t-online.de>
 <874jyeydok.fsf@Rainer.invalid>
From: Jon Turney <jon.turney@dronecode.org.uk>
In-Reply-To: <874jyeydok.fsf@Rainer.invalid>
Precedence: list
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

This is a multi-part message in MIME format.
--------------NR480x0Z6g56UPsnaMC91Dpt
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 14/08/2022 17:47, Achim Gratz wrote:
> Christian Franke writes:
>> This version aborts if "Sync" setting is reverted to "Best".
> 
> If the abort goes away when building setup with the previous version of
> libsolv then you might have found an easier reproducer for a bug I'm
> chasing…  Running it in gdb should get you a SIGSEGV in
> solver_addduprules in this case.

After some staring at this crash and the code involved, I think the 
attached is the fix for this.

I think this crash would only occur if the solver was used with at least 
one package marked for distupgrade, then reused without any.
--------------NR480x0Z6g56UPsnaMC91Dpt
Content-Type: text/plain; charset=UTF-8;
 name="0001-Ensure-duplinvolvedmap_all-is-reset-when-a-solver-is.patch"
Content-Disposition: attachment;
 filename*0="0001-Ensure-duplinvolvedmap_all-is-reset-when-a-solver-is.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA0ODAxMjMwMzg1MzdiODliY2ZjYTRhOGFjOWI0MDI3MWViN2Y1ZDViIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxqb24udHVybmV5QGRyb25lY29k
ZS5vcmcudWs+CkRhdGU6IFN1biwgMTQgQXVnIDIwMjIgMTg6NDU6MjAgKzAxMDAKU3ViamVj
dDogW1BBVENIXSBFbnN1cmUgZHVwbGludm9sdmVkbWFwX2FsbCBpcyByZXNldCB3aGVuIGEg
c29sdmVyIGlzIHJldXNlZAoKT3RoZXJ3aXNlIHRoaXMgY2FuIGNhdXNlIHNvbHZlcl9hZGRk
dXBydWxlcygpIHRvIGJlIGNhbGxlZCBldmVuIHRob3VnaApuZWVkZHVwcnVsZXMgaXMgMCwg
d2hpY2ggd2lsbCBjcmFzaCBiZWNhdXNlIHNvbHZlcl9jcmVhdGVkdXBtYXBzKCkKaGFzbid0
IGJlZW4gY2FsbGVkLgotLS0KIHNyYy9zb2x2ZXIuYyB8IDEgKwogMSBmaWxlIGNoYW5nZWQs
IDEgaW5zZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvc3JjL3NvbHZlci5jIGIvc3JjL3NvbHZl
ci5jCmluZGV4IDI4MzQxZDZkLi5lMzc3OWUyMyAxMDA2NDQKLS0tIGEvc3JjL3NvbHZlci5j
CisrKyBiL3NyYy9zb2x2ZXIuYwpAQCAtMzUzMyw2ICszNTMzLDcgQEAgc29sdmVyX3NvbHZl
KFNvbHZlciAqc29sdiwgUXVldWUgKmpvYikKICAgbWFwX3plcm9zaXplKCZzb2x2LT5iZXN0
dXBkYXRlbWFwKTsKICAgc29sdi0+Zml4bWFwX2FsbCA9IDA7CiAgIG1hcF96ZXJvc2l6ZSgm
c29sdi0+Zml4bWFwKTsKKyAgc29sdi0+ZHVwaW52b2x2ZWRtYXBfYWxsID0gMDsKICAgbWFw
X3plcm9zaXplKCZzb2x2LT5kdXBtYXApOwogICBtYXBfemVyb3NpemUoJnNvbHYtPmR1cGlu
dm9sdmVkbWFwKTsKICAgc29sdi0+cHJvY2Vzc19vcnBoYW5zID0gMDsKLS0gCjIuMzcuMgoK


--------------NR480x0Z6g56UPsnaMC91Dpt
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--------------NR480x0Z6g56UPsnaMC91Dpt--