DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 428BA3857BAF
Date: Sat, 18 Jun 2022 23:23:21 +0300
From: Andrey Repin <anrdaemon@yandex.ru>
Message-ID: <79027388.20220618232321@yandex.ru>
To: Eliot Moss <moss@cs.umass.edu>, cygwin@cygwin.com
Subject: Re: unzip failure with files that contain colons
In-Reply-To: <9093a683-0215-3835-42f5-a8f82975c29f@cs.umass.edu>
References: <20220615183007.7xchz44wwbx2gnio@lucy.dinwoodie.org> 
 <ba73b31b-be25-fe58-98de-11d8cad679cd@towo.net>
 <20220617002939.65c772fc3504f992b6fcf4d9@nifty.ne.jp>
 <9093a683-0215-3835-42f5-a8f82975c29f@cs.umass.edu>
MIME-Version: 1.0
Precedence: list
Reply-To: cygwin@cygwin.com
Content-Type: text/plain; charset="utf-8"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>
Content-Transfer-Encoding: 8bit

Greetings, Eliot Moss!

> On 6/16/2022 11:29 AM, Takashi Yano wrote:
>> On Thu, 16 Jun 2022 06:22:38 +0200
>> Thomas Wolff wrote:
>>> Am 15.06.2022 um 20:30 schrieb Adam Dinwoodie:
>>>> Cygwin generally handles filenames with colons just fine, by mapping the
>>>> character to some higher Unicode character and remapping on the fly.
>>>> However Cygwin's `unzip` appears to have a bug: when unzipping an
>>>> archive that contains a filename with a colon, it replaces the colon
>>>> with an underscore.
>>>>
>>>> cygcheck.out and simple test script attached; expected behaviour from
>>>> running `bash unzip-bug.sh` is that you get an empty file called `a:b`,
>>>> but on Cygwin you instead get an empty file called `a_b`.
>>> It's an explicit #ifdef __CYGWIN__ in upstream unzip, file unix/unix.c,
>>> which transforms a bunch of characters.
>>> If I uncomment most of them (except \), all unpack fine:
>>> x0:z  x1<z  x2>z  x3|z  x4"z  x5?z  x6*z
>> > I have taken over the maintenance of unzip package, and
>> fix the problem in the updated unzip-6.0-18.
>> https://cygwin.com/pipermail/cygwin/2022-June/251653.html

> Is colon used for ADS under Windows?  Could that be why one should
> be careful with it?

Colon is used (aside from being disk-path separator) as file stream indicator.
Replacing it is not strictly correct, in global sense of things, but unpacking
archives is not the place where you'd want to see data stored in multiple
streams.


-- 
With best regards,
Andrey Repin
Saturday, June 18, 2022 23:21:27

Sorry for my terrible english...

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple