DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41D79385041A
Date: Sat, 28 May 2022 23:25:19 +0900
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: Unable to execute Cygwin application within UDF format
Message-Id: <20220528232519.5221a03d560fa140e59d1aeb@nifty.ne.jp>
In-Reply-To: <04783b49-9bd0-da03-805b-d30e6363b7b6@cornell.edu>
References: <CANe7G9EE5Q9kd7FM=+ERhhB2zBxyNo1Tx7Rbuy=X4svaG2m0fw@mail.gmail.com>
 <20220527133120.58530edd99f4a87c605b8a04@nifty.ne.jp>
 <CANe7G9EZbuKOJt_X2mq1X70Y=tWFiy5_w9fnKp59EgCGQjAUAw@mail.gmail.com>
 <20220527181849.6baaa5d9e8446f3e7d23cbee@nifty.ne.jp>
 <20220527195123.abd2d66a17e28b51f1a745a3@nifty.ne.jp>
 <20220527212813.9bdc5d02d5da3172103bbbce@nifty.ne.jp>
 <20220527213629.64893e46789e0e6f7244b0fd@nifty.ne.jp>
 <04783b49-9bd0-da03-805b-d30e6363b7b6@cornell.edu>
Mime-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Sat, 28 May 2022 09:22:12 -0400
Ken Brown wrote:
> On 5/27/2022 8:36 AM, Takashi Yano wrote:
> > diff --git a/winsup/cygwin/cygheap.cc b/winsup/cygwin/cygheap.cc
> > index 01b49468e..34c9e2bc7 100644
> > --- a/winsup/cygwin/cygheap.cc
> > +++ b/winsup/cygwin/cygheap.cc
> > @@ -183,6 +183,11 @@ init_cygheap::init_installation_root ()
> >   	  if (p)
> >   	    p = wcschr (p + 1, L'\\');  /* Skip share name */
> >   	}
> > +      else
> > +	{
> > +	  len = 4;
> > +	  p = installation_root_buf + 4;
> > +	}
> >       }
> >     installation_root_buf[1] = L'?';
> >     RtlInitEmptyUnicodeString (&installation_key, installation_key_buf,
> 
> This looks right to me.  I would just suggest an explanatory comment, something 
> like this:
> 
> +      else  /* Long path prefix followed by drive letter path */

Thanks for the advice. I will submit the patch to cygwin-patches
mailing list.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple