DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 458763858413
Date: Sat, 7 May 2022 05:13:23 +0900
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: mintty crashes on Windows 7
Message-Id: <20220507051323.a6f1116ded86123e8c14993d@nifty.ne.jp>
In-Reply-To: <nycvar.QRO.7.76.6.2205062109380.346@tvgsbejvaqbjf.bet>
References: <CAGHpTB+t+gCySabZZQvJstZSLresmoOTUUL8of9cwCdvmGySdg@mail.gmail.com>
 <CAGHpTB+3V98eWDaHv7DCa133KWS39FaDFMUo=8qOJjxTFon51A@mail.gmail.com>
 <20220504011018.7c455cedb38571f786d72ae9@nifty.ne.jp>
 <CAGHpTBJyOgYAzEvs3NLb8AzkiujbCKjaf+w-QSJAou47g-J-Cg@mail.gmail.com>
 <CAGHpTB+tZX+z0ZkCNG-42bp4Pw+YKUXkccnnNqwN_tHRekk=UA@mail.gmail.com>
 <20220504201610.125888f234ffe063fa6773c0@nifty.ne.jp>
 <CAGHpTBKphe_jSRS+9ihygODYGYYyzPfLPkt9H4rTDm9u7pMexw@mail.gmail.com>
 <20220505102045.fd6bfd46732e2eab0451e28c@nifty.ne.jp>
 <20220505102724.11b5675450f2b4f723a8b70e@nifty.ne.jp>
 <20220505105954.e910df2e6998d130a9373299@nifty.ne.jp>
 <20220505123307.e745d7c88877316b9a38d0c9@nifty.ne.jp>
 <20220505134120.242af45a631131d7e4217f5e@nifty.ne.jp>
 <20220505154440.d9002cc94e7d52b3c6c1f339@nifty.ne.jp>
 <20220506074851.3ce94db7a3ab2bedf7e07f93@nifty.ne.jp>
 <CAGHpTBJRbqTf_2rmXD8413940+At+KS6_2C_702xR0t-L7aVSg@mail.gmail.com>
 <nycvar.QRO.7.76.6.2205062109380.346@tvgsbejvaqbjf.bet>
Mime-Version: 1.0
Precedence: list
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
        Orgad Shaneh <orgads@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Fri, 6 May 2022 21:16:10 +0200 (CEST)
Johannes Schindelin wrote:
> Takashi, for the record, I find it hard to believe that the bug is
> libreadline's because Orgad's scenario works if he reverts that patch in
> the _MSYS2 runtime_, _and_ it is rather dubious that libreadline would
> potentially do anything that makes a call to `GetProcessWindowStation()`
> not fail but _crash_.

I found the following test case also crashes with that commit.

1) Compile rl_stc.c with gcc rl_stc.c -lreadline -o rl_stc.c
2) mintty --hold always ./rl_stc

/* rl_stc.c */
#include <stdio.h>
#include <stdlib.h>
#include <readline/readline.h>

int main(int argc, char *argv[])
{
    char *str;
    if (argc > 1) {
        str = readline(">> ");
        printf("%s\n", str);
        free(str);
    }
    return 0;
}

In this test case, no args is specified, so readline() is
not called. However, this crashes indeed. This means just
loading msys-readline8.dll causes the crash.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple