DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D05E3858D3C
Date: Thu, 5 May 2022 10:59:54 +0900
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: mintty crashes on Windows 7
Message-Id: <20220505105954.e910df2e6998d130a9373299@nifty.ne.jp>
In-Reply-To: <20220505102724.11b5675450f2b4f723a8b70e@nifty.ne.jp>
References: <CAGHpTB+t+gCySabZZQvJstZSLresmoOTUUL8of9cwCdvmGySdg@mail.gmail.com>
 <20220504002343.4345bfe1630fa904276f0d37@nifty.ne.jp>
 <CAGHpTB+3V98eWDaHv7DCa133KWS39FaDFMUo=8qOJjxTFon51A@mail.gmail.com>
 <20220504011018.7c455cedb38571f786d72ae9@nifty.ne.jp>
 <CAGHpTBJyOgYAzEvs3NLb8AzkiujbCKjaf+w-QSJAou47g-J-Cg@mail.gmail.com>
 <CAGHpTB+tZX+z0ZkCNG-42bp4Pw+YKUXkccnnNqwN_tHRekk=UA@mail.gmail.com>
 <20220504201610.125888f234ffe063fa6773c0@nifty.ne.jp>
 <CAGHpTBKphe_jSRS+9ihygODYGYYyzPfLPkt9H4rTDm9u7pMexw@mail.gmail.com>
 <20220505102045.fd6bfd46732e2eab0451e28c@nifty.ne.jp>
 <20220505102724.11b5675450f2b4f723a8b70e@nifty.ne.jp>
Mime-Version: 1.0
Precedence: list
Cc: Orgad Shaneh <orgads@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Thu, 5 May 2022 10:27:24 +0900
Takashi Yano wrote:
> On Thu, 5 May 2022 10:20:45 +0900
> Takashi Yano wrote:
> 
> > On Wed, 4 May 2022 16:27:43 +0300
> > Orgad Shaneh  wrote:
> > > On Wed, May 4, 2022 at 2:16 PM Takashi Yano <takashi.yano@nifty.ne.jp> wrote:
> > > >
> > > > > Reduced the revert to this:
> > > > > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> > > > >         code does not work as expected because it calls Win32
> > > > >         API directly rather than cygwin read()/write(). Due to
> > > > >         this behaviour, protection based on attach_mutex does
> > > > >         not take effect. */
> > > > >      get_ttyp ()->need_invisible_console = true;
> > > > > -  else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > > > > -    && (!get_ttyp ()->invisible_console_pid
> > > > > -        || !pinfo (get_ttyp ()->invisible_console_pid)))
> > > > > -    /* Create a new invisible console for each pty to isolate
> > > > > -       CTRL_C_EVENTs between ptys. */
> > > > > -    get_ttyp ()->need_invisible_console = true;
> > > > >    else
> > > > >      {
> > > > >        acquire_attach_mutex (mutex_timeout);
> > > > >        fhandler_console::need_invisible ();
> > > > >        release_attach_mutex ();
> > > >
> > > > A few things about this.
> > > >
> > > > 1) bash exits with exit code 127 for 'mintty bash'
> > > > 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh' work.
> > > 
> > > Right. mintty dash also works.
> > > 
> > > Notice that I did *not* set enable_pcon (not supported on Win7 anyway).
> > 
> > Even without that commit (and also with msys2 3.3.4 release),
> > something wrong with msys2 in Windows 7.
> > 
> > If you run script command (/usr/bin/script), bash crashes in
> > similar way. typescript file generated by script command is
> > as follows.
> > 
> > Script started on 2022-05-05 10:12:28+09:00 [TERM="cygwin" TTY="/dev/cons0" COLUMNS="80" LINES="25"]
> > 
> > Script done on 2022-05-05 10:12:29+09:00 [COMMAND_EXIT_CODE="127"]
> > 
> > bash also exited with exit code 127.
> 
> Ah, this only occurs if script command is started in console.

And also this is caused by:
get_ttyp ()->need_invisible_console = true;
at another place.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple