DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE599385B83A
Message-ID: <eef4ada5-0ace-d828-c163-988390aa35e0@dronecode.org.uk>
Date: Tue, 1 Feb 2022 20:33:10 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH cygport 1/2] postinst: Never remove an existing
 .gnu_debuglink
Content-Language: en-GB
To: The Cygwin Mailing List <cygwin@cygwin.com>
References: <20220201172519.14881-1-jon.turney@dronecode.org.uk>
 <20220201172519.14881-2-jon.turney@dronecode.org.uk>
 <YfmIbMQvjqL8yW3S@calimero.vinschen.de>
From: Jon Turney <jon.turney@dronecode.org.uk>
In-Reply-To: <YfmIbMQvjqL8yW3S@calimero.vinschen.de>
Precedence: list
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On 01/02/2022 19:22, Corinna Vinschen wrote:
> Hi Jon,
> 
> On Feb  1 17:25, Jon Turney wrote:
>> Be more careful not to remove an existing .gnu_debuglink, even if we
>> think this package has no useful debug symbols.
>>
>> (Some versions of 'llvm-objdump -l' fail to find line number info even
>> though it's there.  Don't break a package which manages it's own debug
>> symbols (e.g. cygwin) when that happens.)
>> ---
>>   lib/src_postinst.cygpart | 28 ++++++++++++++++++----------
>>   1 file changed, 18 insertions(+), 10 deletions(-)
>>
>> diff --git a/lib/src_postinst.cygpart b/lib/src_postinst.cygpart
>> index d8bb226..e29b2cb 100644
>> --- a/lib/src_postinst.cygpart
>> +++ b/lib/src_postinst.cygpart
>> @@ -1051,23 +1051,31 @@ __prepstrip() {
>>   
>>   			lines=$(${objdump} -d -l "${exe}" 2>/dev/null | sed -ne "s|.*\(/usr/src/debug/${PF}/.*\):[0-9]*$|\1|gp" | sort -u | tee -a ${T}/.dbgsrc.out | wc -l);
> 
> Shouldn't lines be computed *after* the new check for .gnu_deb?  After
> all, it's still pretty time-consuming and if the .gnu_deb check kicks in
> it's never tested...

The objdump invocation has the side effect of creating ${T}/.dbgsrc.out, 
which is later used to determine what source files to put into the 
debuginfo package.


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple