DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9ADD0385843E
Date: Mon, 17 Jan 2022 20:41:31 +0900
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: Segmentation fault due to double free for archetype.
Message-Id: <20220117204131.b1b3e221874af6804791ccec@nifty.ne.jp>
In-Reply-To: <YeVMn4MIgG+6T01I@calimero.vinschen.de>
References: <20220115192030.de26356820d839eec3227e70@nifty.ne.jp>
 <YeVMn4MIgG+6T01I@calimero.vinschen.de>
Mime-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Mon, 17 Jan 2022 12:01:51 +0100
Corinna Vinschen wrote:
> On Jan 15 19:20, Takashi Yano wrote:
> > I also found the following patch fixes the issue. Is this the
> > right thing?
> > 
> > diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc
> > index fc7c0422e..e51208117 100644
> > --- a/winsup/cygwin/fhandler.cc
> > +++ b/winsup/cygwin/fhandler.cc
> > @@ -441,7 +441,7 @@ fhandler_base::open_with_arch (int flags, mode_t mode)
> >  	|| open (flags, mode & 07777)))
> >      {
> >        if (archetype)
> > -	delete archetype;
> > +	cygheap->fdtab.delete_archetype (archetype);
> >      }
> >    else if (archetype)
> >      {
> 
> Good catch!  I think this is basically ok, but you have to check the
> usecount, i. e.
> 
>   if (archetype && archetype_usecount (-1) == 0)
>     cygheap->fdtab.delete_archetype (archetype);
> 
> Does that sound right?

Where is archetype->usecount is incremented? It seems that
archetype->usecount is zero here. archetype->usecount is not
incremented around line 672 in dtable.cc when archetype is
created by fh->clone().

  else
    {
      if (!fh->get_name ())
        fh->set_name (fh->dev ().native ());
      fh->archetype = fh->clone ();
      debug_printf ("created an archetype (%p) for %s(%d/%d)", fh->archetype, fh->get_name (), fh->dev ().get_major (), fh->dev ().get_minor ());
      fh->archetype->archetype = NULL;
      *cygheap->fdtab.add_archetype () = fh->archetype;
    }

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple