DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EBAC3858023
Subject: Re: mmap failure [was: cygrunsrv + sshd + rsync = 20 times too slow
 -- throttled?]
To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" <lavr@ncbi.nlm.nih.gov>
References: <YTJ9wwbHqeoGxZMP@calimero.vinschen.de>
 <c54c8815-44fe-a837-211e-6497a185c2e8@cornell.edu>
 <88fde5d5-4897-8792-576a-a62be0092ad8@cornell.edu>
 <94b5b6cf-1670-cbdd-2f51-84dae09d27b6@cornell.edu>
 <387d9062-1ff9-6eab-e268-e5070352a193@cornell.edu>
 <40275f71-7c10-55a9-e6c8-a948e32c37ac@cornell.edu>
 <YTY0oN9x7wNtJAKx@calimero.vinschen.de>
 <d3c9bb17-b859-e7b1-d7e6-c421d0f37836@cornell.edu>
 <33ae27cb-4e45-7484-40d1-6cbd88c958f1@cornell.edu>
 <YTZXGlvWWUk23bJI@calimero.vinschen.de>
 <YTZY/vytb7nagC6M@calimero.vinschen.de>
 <3a63eb8c-3e8e-cd2c-b9de-8c34fa041a75@cornell.edu>
 <5b705ae7c9747a9cc25d2610cc6748e92bbe1d70.camel@dontech.dk>
 <890dad21-dec5-cdd1-bf99-bdb45e759a71@cornell.edu>
 <742331ee-4d9f-e86f-9314-c85b5f0cbfa8@SystematicSw.ab.ca>
 <3bb3814c-0584-c918-6710-f71c7abfbcc5@cornell.edu>
 <SJ0PR09MB7102405FB7D88E4AF44E9498A5D39@SJ0PR09MB7102.namprd09.prod.outlook.com>
Message-ID: <07cb816c-0bca-440d-338d-fefb110d4a41@cornell.edu>
Date: Tue, 7 Sep 2021 18:44:54 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <SJ0PR09MB7102405FB7D88E4AF44E9498A5D39@SJ0PR09MB7102.namprd09.prod.outlook.com>
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?i+QbfMb2VHx+SlE66AoymGhOTUC9+/Zsjaim1QWmuVjQ0SEhauY3esRT?=
 =?Windows-1252?Q?rGLHOd622EP/KCtr852df3Ps7So1fcQ7dIJCP3ej1Ee9mBl33/HsCB+G?=
 =?Windows-1252?Q?q4ZWVcNax9FVQmsuiH/GVCquSsLGO3cuWbYjpmO5ceaLpW/JId48Fn7N?=
 =?Windows-1252?Q?sr8YDUG/7yJHxXwiafq1zYxQfx9yPbLWBX2Ukx0sliN8ffVozuyuqm4i?=
 =?Windows-1252?Q?TgwkCY8Jre3qO0xZ73n416iPYSZdXHR1h9h55Iw4g+e8HExsg/jwZeFm?=
 =?Windows-1252?Q?MK2tG8/IebCOuwMcZkiRM02aexrQOh+EIAJByJtaKJS5CU89iMr3UmqY?=
 =?Windows-1252?Q?ke76k/mU6feRhTON9baO7VMBDaf/0hBDO0bnnB3Edj/QK6SKFqp+tCs6?=
 =?Windows-1252?Q?WzlsTx7GKfzN6mOooSSqztClqKMciAKOv6FXsnvu5BBr2T/lKFCCPUEf?=
 =?Windows-1252?Q?A0j/49oIwbb81WaiHjE3N7+rUetcxDhf1zbgxqkMv4Xy/TtboFNCednO?=
 =?Windows-1252?Q?5FSLBAsdtZtETlI30MoS9kRrRNE9cUOgXBZB4yqVBq4xbOnX7nv9HT3f?=
 =?Windows-1252?Q?40oYhTMU/t3E/acftZ3iF/BnRfkA3X/AUF1heVpeoAQgnLb+2T7V7TvG?=
 =?Windows-1252?Q?Smi+zqIUzupKuvq4BFQm2yu4L4aU2qx3D5q8A8lX2ChYtXKdq3E9da6F?=
 =?Windows-1252?Q?YQUCCOf6PtjTqkVr99TJrxRmWADcmmCZomlRjDugF/xoCYH+gwB0kvwA?=
 =?Windows-1252?Q?mApoSKbbS7rIcizkHY0n3LTbetyCJm8sNPO8GXxO/5Ajrdfrp0HPTa6O?=
 =?Windows-1252?Q?HeYM7o0EUo/sS1LAkTJCnQeiH9PEGTz7p3SQW6TqXO8zdnsMgajOhnD9?=
 =?Windows-1252?Q?FRGtNxujq2e2DIBMIU5dXfnacE8NlR9U7e829/chBpAFcy5kr4Y00Dnb?=
 =?Windows-1252?Q?WM+QDoTbyAjZ5/PMidQhP7yVbz5uKDq2eT3i3ektaRRKqHVXeNczWTWS?=
 =?Windows-1252?Q?57/QPKpSw/Zl1ijHPHFxilTvdylkWOXf2PR2YzvZDML6nJFyMc8nH8Tv?=
 =?Windows-1252?Q?bKNHmI67XPLsaGuTyYeEZXCssxSiPb7G1riy3EQrEjGX+nrZgw7A8YI+?=
 =?Windows-1252?Q?p3tFx8omek7aZP+nW/Ha0Z6fBDKcSVWwDXNlWPz/LvSER+Xshqyj+zcn?=
 =?Windows-1252?Q?GSTaEEWHtPLrfQVY7KORVaj+GIv99rjuAHPBAuM4zxiqyar2vFAsjN6x?=
 =?Windows-1252?Q?kVW1AIhoQw+GohnssGslU9ioSgB0++TNJTCK0qJBtlY29qFNEp9JQDhh?=
 =?Windows-1252?Q?+sgtgJJMGOuc9TY9Eencyb7jTVYHO8VVS95GHHOflCiVjsN7HtVW1ASn?=
 =?Windows-1252?Q?uv49htci7U4hTdoIVWbRW9VIfxxzaANLZOpaOh98/WVH3X3oWa0ExxXG?=
 =?Windows-1252?Q?3W8t3RbLmp6LSft+bplhd0cJJzhlir86SRgjj40ROvPXfq9Jrflp/vI7?=
 =?Windows-1252?Q?P/JAm65y?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: 00496634-2fa8-40c3-aa39-08d972511d57
X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 22:44:56.1196 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EpqK49FzLSnuQUo3Fmq+pd/03fo580IOy2DH4im2j60EJONTASADfP1FIR56A0sle7MFQWtLdz5DkyniBtUMbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR04MB2324
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A,
 RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin@cygwin.com>
Reply-To: Ken Brown <kbrown@cornell.edu>
Cc: "'cygwin@cygwin.com'" <cygwin@cygwin.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On 9/7/2021 5:52 PM, Lavrentiev, Anton (NIH/NLM/NCBI) [C] wrote:
>>>
>>> With undocumented structure member initialization an issue, maybe better to
>>> future proof using e.g.
>>>
>>>       MEM_EXTENDED_PARAMETER mmap_ext = { 0 }; // or memset or bzero
>>
>> I don't see what this would accomplish.  We're already initializing every member
>> after Corinna's last patch.
>>
> 
> Well, if one day MS decides to use some of the Reserved field by splinting off a new
> named field out of that bulk of bits, the code will be in trouble again...
> While with memset, bzero or C-style initializer, everything is guaranteed to be zapped with 0.

MS can't add a new named field to a documented struct without breaking a lot of 
code.  I think it's extremely unlikely that they would do that.  On the other 
hand, I think it's very likely that a reader of the Cygwin code would be 
confused by code that initializes a struct to 0 prior to assigning a value to 
every member.

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple