DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7B483857C60
Subject: Re: mmap failure [was: cygrunsrv + sshd + rsync = 20 times too slow
 -- throttled?]
To: Peter Dons Tychsen <pdt@dontech.dk>, cygwin@cygwin.com
References: <YTJ9wwbHqeoGxZMP@calimero.vinschen.de>
 <c54c8815-44fe-a837-211e-6497a185c2e8@cornell.edu>
 <88fde5d5-4897-8792-576a-a62be0092ad8@cornell.edu>
 <94b5b6cf-1670-cbdd-2f51-84dae09d27b6@cornell.edu>
 <387d9062-1ff9-6eab-e268-e5070352a193@cornell.edu>
 <40275f71-7c10-55a9-e6c8-a948e32c37ac@cornell.edu>
 <YTY0oN9x7wNtJAKx@calimero.vinschen.de>
 <d3c9bb17-b859-e7b1-d7e6-c421d0f37836@cornell.edu>
 <33ae27cb-4e45-7484-40d1-6cbd88c958f1@cornell.edu>
 <YTZXGlvWWUk23bJI@calimero.vinschen.de>
 <YTZY/vytb7nagC6M@calimero.vinschen.de>
 <3a63eb8c-3e8e-cd2c-b9de-8c34fa041a75@cornell.edu>
 <5b705ae7c9747a9cc25d2610cc6748e92bbe1d70.camel@dontech.dk>
 <890dad21-dec5-cdd1-bf99-bdb45e759a71@cornell.edu>
Message-ID: <a3fe25e9-df67-2d80-482a-3e8b9060cd44@cornell.edu>
Date: Mon, 6 Sep 2021 17:31:46 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <890dad21-dec5-cdd1-bf99-bdb45e759a71@cornell.edu>
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?E6WvfEW+62510LGeU/a0z+fUsCcpVfYD+zOfy5WueCImpsl3NFjiEGhz?=
 =?Windows-1252?Q?RVKa/D61QkUrBkPjoMnXZQm+GUek3+2X2ahL3kWIHz5yT6286p8w+elK?=
 =?Windows-1252?Q?gT9+BQa7YoPtx7ejqLQMei8LjPLIMbdJ0EpPgLRz/RXLJw91gohzbT0W?=
 =?Windows-1252?Q?a0skfT2lsmvbrNLgEuUK9HoGQw6Opcn+497BWwVggRQb/FQ3q/uUftpx?=
 =?Windows-1252?Q?UqAdFG6WWpPvdrOKkpXLbGHFEEMvDFv+iTOAdjq7B6jEPoePr4u+YPqX?=
 =?Windows-1252?Q?0u02VPysjQ5vEPROgSfQTVNfx4rMrHBMSYxecOdMnGM5i8LiAFOzxJ7I?=
 =?Windows-1252?Q?N48VSa+ATXaPDP1GitoP9fReffhWG4plxkUcOm485wkoG0qBmbPD9cIV?=
 =?Windows-1252?Q?sZLw7iuFNcwLKiWvSspDVhSA9Xv9Y+Nza2OIt/SQ/K0cJ21ZIqw6W1T4?=
 =?Windows-1252?Q?v9jnGKUBRMdOXeqojPzmORU6J+z9mpD2Muc1+ZIYsG1PAx29Ag3ymU0y?=
 =?Windows-1252?Q?Ha87EF2hRSVRexy/uCDxCZgYawu7MvG6dyYulVd/eaxKaEfym7zkzxP1?=
 =?Windows-1252?Q?dLcDaaILX90eG6+81JrXMPQDIL+V+1NDA/GXQ1dM+bWyQRZTS2i5VLZh?=
 =?Windows-1252?Q?HaRLgP3i29REGPjwHGCBv7dVYjetyTgGmtIUE7JHy/kuAnSJpsWb9NN6?=
 =?Windows-1252?Q?/91tU7APIP6usyGnGLw93REPaeY3ds6XKHUNKY2MYxVt2pv+B1Huyc/p?=
 =?Windows-1252?Q?P6RKg8RcqQThZ8y5D9NsM1HDhchbCM0RWnwSsfleQQB6/WfTn3PZQjng?=
 =?Windows-1252?Q?W+jvWzs6vY+hkIMQPxdhi8aGoSsnXrjm+0QF94VREelZ0nL2wQccP3EZ?=
 =?Windows-1252?Q?+8UnEDWPQP7a/nwm3wcoZq22YvqDNmfhbRhJ35/AuoR4qNzX/VPvVwqK?=
 =?Windows-1252?Q?nnXtxPiONFNi+5ZA4IVVkojltK5SHRsABzK8M8OHqVfciniv6TaecvIr?=
 =?Windows-1252?Q?Gx5cbYiaj3gYzoVHTQHJD99lKoAJI8BzJIjuMONmIrlmnKStMS+uNxq+?=
 =?Windows-1252?Q?M3v2NaDbFocew7/GTLaRS5QZe3ZXluiV7Er9KbTtAQq7I/FEcV7s/8vH?=
 =?Windows-1252?Q?IrJEP9TNYMt2oWftc8+nshFs1l+jG1udAMwk+9YhLPTBivq3nAumDRZQ?=
 =?Windows-1252?Q?WEC6IvN02W/FkT0a3169xbqPiAQSrjx2i1YEA0V+c3sgJ2DJF/oYTMZv?=
 =?Windows-1252?Q?bvWnanRxXMUGhW8giZM1/fNzrwNcwslcHORjbwwqNZRPWhdoDfO0p2vA?=
 =?Windows-1252?Q?GDlBnxy4fycF0h3zsUF0DuXe6UqB4qCb6+G7OEqHYequZ6koNm5C1AT7?=
 =?Windows-1252?Q?33g85B0jeU51zNrxZqP1z4fFuHrQSQE+bFQhQGCfTzfrRWMFS0S0sBGU?=
 =?Windows-1252?Q?b2KvzZB42nY21FCLiE0kwULCC17bB+YQvQ4pZbckpmSKwzU9vhzPBrox?=
 =?Windows-1252?Q?KGP56kpX?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: b8e8c3d3-4805-4a26-2b8f-08d9717dbb85
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB4399.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 21:31:48.1572 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kf/6LtLZ6GxLP8h5r90QgQuC8uXXfJXbVjeLD/gy1PvVIdi+LgB2iMRzw+uXUHiGsz5yCgjekJPrYILkV/k9DA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB3808
X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER,
 NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin@cygwin.com>
Reply-To: Ken Brown <kbrown@cornell.edu>
Content-Type: text/plain; charset="windows-1252"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id 186LX4qX022048

On 9/6/2021 5:24 PM, Ken Brown via Cygwin wrote:
> On 9/6/2021 4:54 PM, Peter Dons Tychsen wrote:
>> Hi there,
>>
>> On Mon, 2021-09-06 at 14:40 -0400, Ken Brown via Cygwin wrote:
>>>> No, wait.  I get what you say.  The optimzation settings of the test
>>>> case should have no influence on the code inside the DLL.  That
>>>> doesn't
>>>> make sense for sure.  However, I ran the testcase under GDB, I could
>>>> reproduce the issue, and I could fix it by setting mmap_ext.Reserved
>>>> = 0;
>>>> Go figure!
>>>
>>> I don't get it, but I can confirm that the problem is fixed.
>>
>> That sounds a bit like a voodoo fix, that could quickly regress again.
>>
>> Here is my 2 cents:
>>
>> Currently the mmap_ext structure is setup like this:
>>
>>   215       MEM_EXTENDED_PARAMETER mmap_ext = {
>>   216         .Type = MemExtendedParameterAddressRequirements,
>>   217         .Pointer = (PVOID) &mmap_req
>>   218       };
>>
>> This means that all other entries in the struct are zero at
>> initialization as described here:
>> https://en.cppreference.com/w/c/language/struct_initialization
>>
>> So if you set "mmap_ext.Reserved = 0" again after that its a double
>> failure.
> 
> You're looking at the wrong source code.  The bug didn't occur until the code 
> was changed to do the following:
> 
>        /* g++ 11.2 workaround: don't use initializer */
>        MEM_EXTENDED_PARAMETER mmap_ext;
>        mmap_ext.Type = MemExtendedParameterAddressRequirements;
>        mmap_ext.Pointer = (PVOID) &mmap_req;
> 
> This left mmap_ext.Reserved uninitialized, which Corinna has now fixed.

I should add that when I said "I don't get it", I wasn't referring to Corinna's 
fix.  I was referring to the fact that the bug did *not* occur when the 
unoptimized build was run under gdb.

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple