DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D0473858439
Subject: Re: mmap failure [was: cygrunsrv + sshd + rsync = 20 times too slow
 -- throttled?]
To: Peter Dons Tychsen <pdt@dontech.dk>, cygwin@cygwin.com
References: <YTJ9wwbHqeoGxZMP@calimero.vinschen.de>
 <c54c8815-44fe-a837-211e-6497a185c2e8@cornell.edu>
 <88fde5d5-4897-8792-576a-a62be0092ad8@cornell.edu>
 <94b5b6cf-1670-cbdd-2f51-84dae09d27b6@cornell.edu>
 <387d9062-1ff9-6eab-e268-e5070352a193@cornell.edu>
 <40275f71-7c10-55a9-e6c8-a948e32c37ac@cornell.edu>
 <YTY0oN9x7wNtJAKx@calimero.vinschen.de>
 <d3c9bb17-b859-e7b1-d7e6-c421d0f37836@cornell.edu>
 <33ae27cb-4e45-7484-40d1-6cbd88c958f1@cornell.edu>
 <YTZXGlvWWUk23bJI@calimero.vinschen.de>
 <YTZY/vytb7nagC6M@calimero.vinschen.de>
 <3a63eb8c-3e8e-cd2c-b9de-8c34fa041a75@cornell.edu>
 <5b705ae7c9747a9cc25d2610cc6748e92bbe1d70.camel@dontech.dk>
Message-ID: <890dad21-dec5-cdd1-bf99-bdb45e759a71@cornell.edu>
Date: Mon, 6 Sep 2021 17:24:53 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <5b705ae7c9747a9cc25d2610cc6748e92bbe1d70.camel@dontech.dk>
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?iRNw+mDTLIYDF2BPqyj+XmMkhO3/0drgHeKFvhNz4iZ/MXoBrRdAzhYb?=
 =?Windows-1252?Q?3xpq7hC/gFoMP+jznDdnByIu2qCa2/TCEicDFFln7P5SbMqtYkfaKecD?=
 =?Windows-1252?Q?qDIP0/bSVYvC1bfh4lN//2EQFCMUZ+1JEVy+UBgtQ8iHJf0R9WL9x5zL?=
 =?Windows-1252?Q?+khWjpKkSwnqf9hk0wbk2PmGDGnOM+5kT7fxifPh/5QV1qHJJnMyoe+L?=
 =?Windows-1252?Q?dPzkt0N3OGOq55sab36w+ZIdef4nZ5do6vb/+/9i8hd39MjBJZdxEcBf?=
 =?Windows-1252?Q?AffsBENeRPl7QRoYHN4MSAJ1DCmKshA6xcqkeCyzapDbrXoox6tmu9Vi?=
 =?Windows-1252?Q?ged8pbX667nRaoXqN/1dvuVWEkFV100GQZRoZ3Dyd076w3PwrRbp4/ow?=
 =?Windows-1252?Q?zRthIO+ikXuBEm8Ms8/FemAPpv+vxE5RESxZWcTfbTKg5vXUAHV7rp0l?=
 =?Windows-1252?Q?t1HtSaeqGrXUaIbQCAdN23+IewLtt6V77vHC4c/e5kM8b2uKlbWGAYoE?=
 =?Windows-1252?Q?fOqQHzVGdwpYQaIBLiQ+ZA4DajeJitwFDOf/r17UxNjtghniJ2YddDA9?=
 =?Windows-1252?Q?N0iOcZh4QVyvcLN4AhnuovsjbmlZ5EDd2EHSOTeFRS8XD+/XgrSxDsZh?=
 =?Windows-1252?Q?LBV1/VY+NOOBWp5IihsRYLmOjQvJOXBkOticyVtVgEacBTt2TvNpQV4Q?=
 =?Windows-1252?Q?e36YqXDatxRcynffiH639AhZME8Uq/OiXSZ1dkN8edaXZVkjJ2L7f8Yv?=
 =?Windows-1252?Q?r8n9eQzqttAZK3xxRvEl1He7NBFXKnjJaGD7NQgy9Xzyn6Q2ycDwPyQg?=
 =?Windows-1252?Q?jEbV8j9uCzECp97xd7ypYkO9rvReFjS7UWbcOBLMnMfw5qyQth3bWtuu?=
 =?Windows-1252?Q?AbA+ndk3W7xVZLYNFF50i3xuOXqE8Nf7DrIOv7Rbvcavkoc9yREYNl3l?=
 =?Windows-1252?Q?Xics8pP+TInXXXG5H0QabtPV3UoChPgT/uEB0dH956SXHDtLNT/T48DM?=
 =?Windows-1252?Q?crX9sTXWVXi2wV0le7sHO7oDLjV5VJ/pX5/1i1PcexmiCo92b4JQFCKl?=
 =?Windows-1252?Q?61UU6YQFrEbVkGGSBJX7XoZKqZwVXf1OBaMAYk+tDUf7O6pOrKUqZ682?=
 =?Windows-1252?Q?MHdkTk43x71qzf5iRSL6hrl9d+Fdl7WuTW6Oo4bTjt3S8XsbByCFysa2?=
 =?Windows-1252?Q?1pmOIjBhIjBvLqXKg66kOcXbneEIFhRzB+O5iMOAN9CJka8CWOxlTp6M?=
 =?Windows-1252?Q?qR82biiclFJ+116sQdmX4R8lJhuyPWOkaUYLbuna01HfOxbPsJ92A537?=
 =?Windows-1252?Q?Bi5zG79mvaOHenx5LxPtVXUwI/XIdsq6cK2WklGvhU/Ohj5yBG6R0C3y?=
 =?Windows-1252?Q?HbEBrKslBj1nQBAPuk1lEu0DaTUpFLh8mU3Yce8qKY70WjgjgyVGxpq8?=
 =?Windows-1252?Q?C0LVZsH1HWaYZIe4YKZOYYOvMjTeJ5Xq3iOlavd0KEViyK32vqQXBnno?=
 =?Windows-1252?Q?m4s8vxMV?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b390474-f8f2-4be4-40c0-08d9717cc5d6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB4399.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 21:24:56.0051 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GHKh5k5vX9xgHuJPAVO8NNCNMuQKqXnHU6Ospf30RmwNiT2oOJQkPOYMvaBY4pjoDqVNsIPTMOyCMGqq0aNjwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB5248
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_INVALID,
 DKIM_SIGNED, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER,
 NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request@cygwin.com?subject=subscribe>
From: Ken Brown via Cygwin <cygwin@cygwin.com>
Reply-To: Ken Brown <kbrown@cornell.edu>
Content-Type: text/plain; charset="windows-1252"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id 186LQBSx020834

On 9/6/2021 4:54 PM, Peter Dons Tychsen wrote:
> Hi there,
> 
> On Mon, 2021-09-06 at 14:40 -0400, Ken Brown via Cygwin wrote:
>>> No, wait.  I get what you say.  The optimzation settings of the test
>>> case should have no influence on the code inside the DLL.  That
>>> doesn't
>>> make sense for sure.  However, I ran the testcase under GDB, I could
>>> reproduce the issue, and I could fix it by setting mmap_ext.Reserved
>>> = 0;
>>> Go figure!
>>
>> I don't get it, but I can confirm that the problem is fixed.
> 
> That sounds a bit like a voodoo fix, that could quickly regress again.
> 
> Here is my 2 cents:
> 
> Currently the mmap_ext structure is setup like this:
> 
>   215       MEM_EXTENDED_PARAMETER mmap_ext = {
>   216         .Type = MemExtendedParameterAddressRequirements,
>   217         .Pointer = (PVOID) &mmap_req
>   218       };
> 
> This means that all other entries in the struct are zero at
> initialization as described here:
> https://en.cppreference.com/w/c/language/struct_initialization
> 
> So if you set "mmap_ext.Reserved = 0" again after that its a double
> failure.

You're looking at the wrong source code.  The bug didn't occur until the code 
was changed to do the following:

       /* g++ 11.2 workaround: don't use initializer */
       MEM_EXTENDED_PARAMETER mmap_ext;
       mmap_ext.Type = MemExtendedParameterAddressRequirements;
       mmap_ext.Pointer = (PVOID) &mmap_req;

This left mmap_ext.Reserved uninitialized, which Corinna has now fixed.

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple