DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 457BC3858D34
Date: Sat, 28 Aug 2021 10:43:27 +0200
To: cygwin@cygwin.com
Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled?
Message-ID: <YSn3L0W1M527utK0@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <41A583E1-C8E7-42AB-9F24-EEC33A41EC60@house.org>
 <20210825201845.07b6400b79dc5558a7761efe@nifty.ne.jp>
 <f8106fe7-a2b8-d106-3061-4d888124f4b0@cornell.edu>
 <20210826062934.54f2f2216021c095bb7ba13b@nifty.ne.jp>
 <d0a8c57d-1ed1-6b4f-c6e7-cbe0e2ec8a1c@cornell.edu>
 <3b560051-ab27-f392-ca4b-d1fd9b5733b0@cornell.edu>
 <20210827202440.47706fc2fc07c5e9a1bc0047@nifty.ne.jp>
 <4f2cb5f3-ce9c-c617-f65f-841a5eca096e@cornell.edu>
 <20210828022111.91ef5b4ff24f6da9fadb489e@nifty.ne.jp>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20210828022111.91ef5b4ff24f6da9fadb489e@nifty.ne.jp>
Precedence: list
From: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin@cygwin.com
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On Aug 28 02:21, Takashi Yano via Cygwin wrote:
> On Fri, 27 Aug 2021 12:00:50 -0400
> Ken Brown wrote:
> > Two years ago I thought I needed nt_create to avoid problems when calling 
> > set_pipe_non_blocking.  Are you saying that's not an issue?  Is 
> > set_pipe_non_blocking unnecessary?  Is that the point of your modification to 
> > raw_read?
> 
> Yes. Instead of making windows read function itself non-blocking,
> it is possible to check if the pipe can be read before read using
> PeekNamedPipe(). If the pipe cannot be read right now, EAGAIN is
> returned.

The problem is this:

  if (PeekNamedPipe())
    ReadFile(blocking);

is not atomic.  I. e., if PeekNamedPipe succeeds, nothing keeps another
thread from draining the pipe between the PeekNamedPipe and the ReadFile
call.  And as soon as ReadFile runs, it hangs indefinitely and we can't
stop it via a signal.

Is a blocking ReadFile actually faster than a non-blocking read?  Or
does it mainly depend on BYTE vs. MESSAGE mode?

What if the pipe is created non-blocking and stays non-blocking all the
time and uses BYTE mode all the time?  Just as sockets, it would always
only emulate blocking mode.  Wouldn't that drop code size a lot and fix
most problems?


Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple