DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19EE8385E001
Subject: Re: xwin-xdg-menu high cpu usage with rxvt-unicode
To: Takashi Yano <takashi.yano@nifty.ne.jp>,
        The Cygwin Mailing List <cygwin@cygwin.com>
References: <tY-YzUNrM949zC_VJOeRHb8ZfRSYyZs8VHOJw5uBWmP-sdqzFXneuCcEBsv7N5906q8lQdA0SJXUz13FAv1uaTwY9inYMBGrwh1HHoHH1XA=@protonmail.com>
 <20210623120858.83e471aa7ddbc20cd41efb2c@nifty.ne.jp>
From: Jon Turney <jon.turney@dronecode.org.uk>
Message-ID: <608c8616-52a3-bbfb-f8f0-983a6c4453b1@dronecode.org.uk>
Date: Wed, 23 Jun 2021 17:41:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210623120858.83e471aa7ddbc20cd41efb2c@nifty.ne.jp>
Content-Language: en-GB
Precedence: list
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie.com@cygwin.com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie.com@cygwin.com>

On 23/06/2021 04:08, Takashi Yano wrote:
> On Mon, 21 Jun 2021 05:49:28 +0000
> Viet-Duc Le wrote:
>> Hi,
>>
>> I've encountered a peculiar issue with rxvt-unicode launched from xwin-xdg-menu (20170321-1)
>> The image below corresponds to two rxvt-unicode instances, each occupies 30% of system resouce.
>> https://imgur.com/a/FTFwIrZ
>> I'm using the the latest version of cygwin. 'cygcheck.out' is attached per guideline.
>>
>> Steps to reproduce:
>> - Start XWin Server from Start menu
>> - X applications menu -> System Tools -> rxvt-unicode
>> - Kill rxvt-unicode to free the resource again
>>
>> Other observations:
>> - XTerm does not incur high resources.
>> - Manually launching rxvt-unicode from XTerm does not incur high resources.
>>
>> I think this is not an issue with rxvt but with xwin-xdg-menu.
>> On laptop, it is very noticeable when the fan kicks in.
>> Insights and suggestions are much appreciated.
>>
>> Thanks.
>> Viet-Duc
> 
> I looked into this problem and found the cause.
> urxvt seems to close stdout while xwin-xdg-menu use select()
> to read stdout of the launched apps. Since stdout is closed,
> select() returns repeatedly without any output. This causes
> high cpu load.
> 
> I also confirmed that the following patch for xwin-xdg-menu
> resolves the issue.
> 
[...]
> 
> Jon, could you please have a look?

Thanks very much for looking into this, and the patch.

That looks right.

I applied the patch, and built and uploaded a xwin-xdg-menu-20210623-1 
test package.

Perhaps you could try that, and see if it improves things for you?

(Similar code is used in XWin, so I also need to make a similar change 
there)

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple