DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 24CB53857C50
MIME-Version: 1.0
References: <CAE6_+Uc6rfDPTpOpkLGjn5G9HS77qvHWcEpOOepmC962vbgMmw@mail.gmail.com>
 <20210319190807.babb0c0312740f44e9119c17@nifty.ne.jp>
In-Reply-To: <20210319190807.babb0c0312740f44e9119c17@nifty.ne.jp>
Date: Fri, 19 Mar 2021 12:17:00 +0100
Message-ID: <CAE6_+UcY62tJ=g3DW++HVZzUjaDGYp4N8nAjCtkPbhZF6-Fpug@mail.gmail.com>
Subject: Re: stdin pipe rename in 3.2.0
To: Takashi Yano <takashi.yano@nifty.ne.jp>
From: Christoph Reiter via Cygwin <cygwin@cygwin.com>
Reply-To: Christoph Reiter <reiter.christoph@gmail.com>
Cc: cygwin@cygwin.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

On Fri, Mar 19, 2021 at 11:09 AM Takashi Yano via Cygwin
<cygwin@cygwin.com> wrote:
>
> On Thu, 18 Mar 2021 21:28:40 +0100
> Christoph Reiter wrote:
> > I noticed that the stdin pipe was renamed from
> >
> > "\msys-dd50a72ab4668b33-pty1-from-master" to
> > "\msys-dd50a72ab4668b33-pty0-to-slave" in
> > https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=bb42852062073439
>
> Actually, this is not renamed but newly introduced only
> for non-cygwin (native) apps.

ah, I see.

> > This trips up https://github.com/k-takata/ptycheck to detect the
> > cygpty which is used in various code bases.
>
> If this change is affected, your process seems to be
> a non-cygwin process.

yes, I noticed this with non-cygwin processes.

> > Is there a reason it was renamed?
> >
> > And while grepping I noticed the old name is still checked for in
> > other places like
> > https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/tty.cc;h=3c016315cdedb1dcca44cb3f3f96b87fd0b90a97;hb=HEAD#l162
> > which seems weird.
>
> The name "from-master" is still used for cygwin
> processes.

ok.

> However, the naming was not appropriate.
> The name of output pipes are:
> "ptyNNNN-to-master-cyg" for cygwin process,
> and
> "ptyNNNN-to-master" for non-cygwin process.
>
> However, the name of input pipes are:
> "ptyNNNN-from-master" for cygwin process,
> and
> "ptyNNNN-to-slave" for non-cygwin process.
> This is not only consistent but also very confusing.
>
> I would like to rename these pipes to:
> "ptyNNNN-from-master-cyg" for cygwin process,
> "ptyNNNN-from-master" for non-cygwin process.

If the naming was changed to keep https://github.com/k-takata/ptycheck
working then it would help me a lot. But I also don't mind patching
this on our side.

Thanks!
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple