DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8CFC838708CB
Date: Wed, 10 Mar 2021 20:31:46 +0900
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] cygwin 3.2.0-0.1 (TEST)
Message-Id: <20210310203146.7107c223f5ebdfc037751e55@nifty.ne.jp>
In-Reply-To: <DM5PR19MB098682EB9872B14E3EE7E0C593919@DM5PR19MB0986.namprd19.prod.outlook.com>
References: <announce.20210309120131.360333-1-corinna-cygwin@cygwin.com>
 <DM5PR19MB098682EB9872B14E3EE7E0C593919@DM5PR19MB0986.namprd19.prod.outlook.com>
Mime-Version: 1.0
Precedence: list
From: Takashi Yano via Cygwin <cygwin@cygwin.com>
Reply-To: Takashi Yano <takashi.yano@nifty.ne.jp>
Content-Type: text/plain; charset="utf-8"
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>
Content-Transfer-Encoding: 8bit

On Wed, 10 Mar 2021 03:38:52 +0000
André Bleau wrote:
> Hi,
> 
> Last year, I reported a problem about console output with pcon support. For the simple test program, see:
> https://cygwin.com/pipermail/cygwin/2020-May/244742.html
> 
> I was told (https://cygwin.com/pipermail/cygwin/2020-May/244745.html) that I need to inset the following lines in my program:
> 
> #include <windows.h>
> ...
> DWORD mode;
> GetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), &mode);
> mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
> SetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), mode);
> 
> It worked. 
> 
> Now, I just downloaded cygwin 3.2.0-0.1 and retested my program with and without the above lines. Both work correctly.
> 
> Are the above lines no longer necessary? In that case, it could be useful to say so in the release notes.

This is due to behaviour change of pseudo console itself.
In Win10 20H2 (and perhaps also in 2004),
ENABLE_VIRTUAL_TERMINAL_PROCESSNG is set by default in pseudo
console. However, older Win10 such as 1809, this flag is not
set. Therefore, you need to set this flag explicitly.

Also, in command prompt, this flag is not set even with Win10
20H2. So, I recommend to keep this flag set for portability.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple