DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1BF653951C10
Date: Fri, 5 Mar 2021 15:37:50 +0100
To: cygwin@cygwin.com
Subject: Re: segfault on 32bit cygwin snapshot
Message-ID: <YEJCPu8RmtOv8Z5B@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <7480c946-8e02-aba2-c06f-6b39f630699f@gmail.com>
 <20210301095546.dce31a474bd0cec2c3518f87@nifty.ne.jp>
 <20210301212542.8b1749f92af62c01b008f25a@nifty.ne.jp>
 <20210302200308.62db4fe01f78fb35a538784f@nifty.ne.jp>
 <YD5eXbxBWbUUSwcM@calimero.vinschen.de>
 <20210303185621.b048287526901af6a4c8200a@nifty.ne.jp>
 <YD9sSea32T7GqlJr@calimero.vinschen.de>
 <e15e6d1f-7680-8f80-871e-0d224a3ed682@maxrnd.com>
 <YEEGw4P+vtzejGOv@calimero.vinschen.de>
 <00624789-7d57-4e80-26f0-a48e9893b6c9@maxrnd.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <00624789-7d57-4e80-26f0-a48e9893b6c9@maxrnd.com>
Precedence: list
From: Corinna Vinschen via Cygwin <cygwin@cygwin.com>
Reply-To: cygwin@cygwin.com
Cc: Corinna Vinschen <corinna-cygwin@cygwin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

On Mar  5 01:18, Mark Geisert wrote:
> Hi Corinna,
> 
> Corinna Vinschen via Cygwin wrote:
> > On Mar  4 01:05, Mark Geisert wrote:
> > > Corinna Vinschen via Cygwin wrote:
> > > > Is there a way around that?  I'm not quite sure, so let's brain storm
> > > > a bit, ok?
> > > > 
> > > > - One thing we could try is to remove the above code, but add a python
> > > >     hack to dlsym instead.  This would let the "old" DLLs work again as
> > > >     before and for python we could add a hack to dlsym, along these lines:
> > > > 
> > > >       if (CYGWIN_VERSION_CHECK_FOR_UNAME_X
> > > >       	&& modulehandle == cygwin1.dll
> > > > 	&& strcmp (symname, "uname"))
> > > >         symname = "uname_x";
> > > > 
> > > > Thoughts?  Other ideas?
> > > 
> > > That's a sly fix, but it seems that it would do the job.  That's good!
> > > 
> > > On a different tack, I was thinking about how run time code could tell the
> [...somewhat of a dead-end tangent elided...]
> > However, it's not clear how this fixes the actual problem.  We just
> > don't have a way to know what size the caller expects.
> > 
> > Having version or size info in structs like the Win32 API does in a
> > couple of cases makes a lot more sense now...
> 
> Indeed.  I like your dlsym proposal, but I would code the "modulehandle ==
> cygwin1.dll" first as it's less likely to be true than the version check.
> 
> I think "the above code" you mentioned still needs to be retained to deal
> with old exes calling uname directly and needing the old version.

To the contrary.  That code was only required to deal with *new*
executables calling uname via the old entry point, because they called
dlopen/dlsym("uname").  Given this is handled in dlsym with my above
proposal, that addition in uname should go away.  After all, it's the
reason for the DLL crashes we're talking about here.


Corinna
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple