DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 97807385700B
Subject: Re: python-cython C++ support patch
To: cygwin@cygwin.com
References: <20210129.193143.371461372727925270.trueroad@trueroad.jp>
Message-ID: <7edac602-ab79-7421-f5f8-929c7fa68428@gmail.com>
Date: Fri, 29 Jan 2021 15:18:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210129.193143.371461372727925270.trueroad@trueroad.jp>
Content-Language: it
Precedence: list
From: Marco Atzeri via Cygwin <cygwin@cygwin.com>
Reply-To: Marco Atzeri <marco.atzeri@gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

On 29.01.2021 11:31, Masamichi Hosoda wrote:
> Hi,
> 
> I've found that modules built by python-cython with C++ could not be loaded.
> If I understand correctly, the following patch fixes it.
> Would you like to apply this patch to the package?
> 
> ```
> --- a/Cython-0.29.21/Cython/Utility/ModuleSetupCode.c
> +++ b/Cython-0.29.21/Cython/Utility/ModuleSetupCode.c
> @@ -709,7 +709,11 @@
>   /////////////// PyModInitFuncType.proto ///////////////
>   
>   #ifndef CYTHON_NO_PYINIT_EXPORT
> +#ifdef __cplusplus
> +#define __Pyx_PyMODINIT_FUNC  extern "C" PyObject *
> +#else
>   #define __Pyx_PyMODINIT_FUNC  PyObject *
> +#endif
>   
>   #elif PY_MAJOR_VERSION < 3
>   // Py2: define this to void manually because PyMODINIT_FUNC adds __declspec(dllexport) to it's definition.
> ```
> 
> Thanks.

Thanks Masamichi,

it seems in line with similar patches that I have applied to some
other python sub packages

Have you a test case for this one ?

I will look to rebuilt python-cython after some extra check

Marco


--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple