DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 73572386EC4F
From: ASSI <Stromeko@nexgo.de>
To: cygwin@cygwin.com
Subject: Re: tar 1.33 symlinks : Cannot change mode to...
References: <PU1PR04MB25507BD8BECC57FABE96DC8590AB0@PU1PR04MB2550.apcprd04.prod.outlook.com>
 <1dff3bac-a82e-f30a-a86d-a4dcc08c849b@cornell.edu>
Date: Tue, 12 Jan 2021 09:18:56 +0100
In-Reply-To: <1dff3bac-a82e-f30a-a86d-a4dcc08c849b@cornell.edu> (Ken Brown via
 Cygwin's message of "Mon, 11 Jan 2021 18:50:33 -0500")
Message-ID: <87ft36k1ov.fsf@Otto.invalid>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

Ken Brown via Cygwin writes:
> I can confirm this.  Running the tar command under gdb shows a problem
> at gnu/fchmodat.c:94:
>
> 94            if (S_ISLNK (st.st_mode))

That should be foolproof, but apparently isn't.

> Here st is a stat structure for directory/1, so S_ISLNK() should be
> true.  It is indeed true on 64-bit Cygwin but not on 32-bit Cygwin.
> Someone needs to look more closely and find out why this happened.
> I'll try to do it tomorrow if no one beats me to it.

I might remember wrongly, but I don't think that code was changed
between the two versions.  What's the call stack at that point?

Unfortunately the handful of commits that might change the behaviour for
this situation elsewhere are knotty, so bisecting will not really
help much I'm afraid.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple