DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 375353846035
Date: Wed, 2 Sep 2020 09:54:29 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: cpp /usr/include/threads.h fails; modfl segfaults
Message-ID: <20200902075429.GE4127@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <02b16d2e-9d51-de58-807b-3b31b2565b59.ref@aol.com>
 <02b16d2e-9d51-de58-807b-3b31b2565b59@aol.com>
 <20200830130005.GR3272@calimero.vinschen.de>
 <eba28e06-139b-0d01-afb5-81a67ba1ad16@SystematicSw.ab.ca>
 <20200831073500.GU3272@calimero.vinschen.de>
 <36f6cc1b-1944-f1b6-b832-33205c08bbae@SystematicSw.ab.ca>
 <20200831184517.GF3272@calimero.vinschen.de>
 <140d7709-7db0-6935-15c1-786d392d0f53@SystematicSw.ab.ca>
 <20200831194153.GH3272@calimero.vinschen.de>
 <e36b9548-58b5-b2f7-e5de-7a061c5f38ac@SystematicSw.ab.ca>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <e36b9548-58b5-b2f7-e5de-7a061c5f38ac@SystematicSw.ab.ca>
Precedence: list
Reply-To: cygwin@cygwin.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

On Sep  1 11:28, Brian Inglis wrote:
> On 2020-08-31 13:41, Corinna Vinschen wrote:
> > On Aug 31 13:24, Brian Inglis wrote:
> >>>> The upstream patch changed only amd64/x86_64 code sequences for multiple modules
> >>>> including modfl, and left i386/x86 untouched for those modules.
> >>
> >> Just pointing out that they only modify their amd64/x86_64 code which doesn't
> >> push/pop rax/eax:
> > 
> > Where are you looking at?  As you could see from my output, I was
> > looking at the master branch of the upstream repo.
> 
> Sorry I didn't see your point there as I wasn't aware there were SF repos.
> 
> > This lengthy discussion for a minor asm snippet doesn't make any sense.
> > If you think this is wrong, send patches to cygwin-patches and explain
> > where you got it from, preferrably as a git patch from the upstream
> > repo.
> 
> Sorry for wasting your time.
> I was looking at the bug/patch content and didn't realize someone later added a
> bogus clobber on their x86 code path.

No, really, patches are super great and *I* know *you* know how it works.

Given this code is at least questionable, what about sending a patch to
upstream and a matching patch to cygwin-patches?  The upstream mailing
list is at mingw-w64-public AT lists DOT sourceforge DOT net.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple