DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8EC293851C29
Date: Mon, 31 Aug 2020 09:35:00 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: cpp /usr/include/threads.h fails; modfl segfaults
Message-ID: <20200831073500.GU3272@calimero.vinschen.de>
Mail-Followup-To: cygwin@cygwin.com
References: <02b16d2e-9d51-de58-807b-3b31b2565b59.ref@aol.com>
 <02b16d2e-9d51-de58-807b-3b31b2565b59@aol.com>
 <20200830130005.GR3272@calimero.vinschen.de>
 <eba28e06-139b-0d01-afb5-81a67ba1ad16@SystematicSw.ab.ca>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <eba28e06-139b-0d01-afb5-81a67ba1ad16@SystematicSw.ab.ca>
Precedence: list
Reply-To: cygwin@cygwin.com
Content-Type: text/plain; charset="utf-8"
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>
Content-Transfer-Encoding: 8bit

On Aug 30 14:39, Brian Inglis wrote:
> On 2020-08-30 07:00, Corinna Vinschen wrote:
> > On Aug 29 08:52, airplanemath via Cygwin wrote:
> >> I have two reports.  A brief description of the system:
> >> $ uname -a | sed "s/${HOSTNAME}/\${HOSTNAME}/g"
> >> CYGWIN_NT-10.0 ${HOSTNAME} 3.1.7(0.340/5/3) 2020-08-22 17:48 x86_64 Cygwin
> ...
> >> $ cat test.c
> >> #include <math.h>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >>
> >> int main(int argc, char *argv[]) {
> >>   long double a, b, c;
> >>   char *num_end = NULL;
> >>   a = b = c = 0.0L;
> >>   if (argc != 2) {
> >>     fprintf(stderr, "Usage: %s NUMBER\n", argv[0]);
> >>     exit(1);
> >>   }
> >>   a = strtold(argv[1], &num_end);
> >>   b = modfl(a, &c);
> >>   printf("%Lf %Lf %Lf\n", a, b, c);
> >>   return 0;
> >> }
> > 
> > This is a bug in the assembler code taken from Mingw-w64.  The bug has
> > been fixed upstream, so I just pulled in the upstream fixes.
> 
> The 64 bit fix doesn't pop eax but *now* flags eax as clobbered, whereas the 32
> bit fix both pops and *now* flags eax as clobbered, which it really doesn't need
> to do. Is this inconsistent treatment correct?

You may be right that this is not necessary on i686, but it doesn't
hurt either and I'd like to stick to the upstream code if possible.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple