DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 921F93870900
MIME-Version: 1.0
References: <CAALQ5rnxo0_pJqTo5+617sZ6NPyDEuw5LkK_w5tMihYnTRfHrg@mail.gmail.com>
 <875z95tg5c.fsf@Rainer.invalid>
 <1f4a80f7-0e14-1641-3fce-317ac2a6dd00@dronecode.org.uk>
 <CAALQ5rnsexseL=gNd5VKkZSi2=Feg4vFLFGG8OmFcmVhyKvWoQ@mail.gmail.com>
 <20200827090010.GZ3272@calimero.vinschen.de>
 <CAALQ5rmB41AaANP6n3GNWbO4zLUjSyuuJ+2WwS=PWNqWbp7hXA@mail.gmail.com>
In-Reply-To: <CAALQ5rmB41AaANP6n3GNWbO4zLUjSyuuJ+2WwS=PWNqWbp7hXA@mail.gmail.com>
Date: Thu, 27 Aug 2020 14:48:51 +0200
Message-ID: <CAALQ5rn5=oqGOge7mTFGoDeJCxD6H4=cFN3Mww+My4DMxNPsEQ@mail.gmail.com>
Subject: Re: Forcing setup.exe not to create WSL symlinks
To: The Cygwin Mailing List <cygwin@cygwin.com>
From: Michael Wild via Cygwin <cygwin@cygwin.com>
Reply-To: Michael Wild <themiwi@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

On Thu, Aug 27, 2020 at 11:44 AM Michael Wild wrote:

>
> On Thu, Aug 27, 2020 at 11:02 AM Corinna Vinschen wrote:
>
>> On Aug 27 07:48, Michael Wild via Cygwin wrote:
>> > On Wed, Aug 26, 2020 at 10:57 PM Jon Turney wrote:
>> >
>> > >
>> > > It turns out to be the case that setup doesn't propagate the CYGWIN
>> > > environment variable into the environment for scripts it runs, so
>> > > setting that isn't going to make any difference.  That should probably
>> > > be considered a bug.
>> > >
>> > > However, even if that's fixed, there's no value for winsymlinks in
>> > > CYGWIN env var to specify the behaviour of Cygwin 3.1.4 and previous
>> > > (i.e. always create traditional symlinks, don't use WSL symlink
>> reparse
>> > > points)
>> > >
>> >
>> > Thanks Jon for the elaboration. Isn't winsymlinks=lnk supposed to do
>> this
>> > per the documentation? Could Corinna be convinced to include an option
>> > where this can be done? To be honest, my hopes are greater to get this
>> > worked-around in a useful timeframe from the Cygwin side than getting
>> the
>> > proper fix into Docker.
>>
>> Isn't it sufficient to fix setup so you can create lnk-style symlinks in
>> your scenario?  The CYGWIN env variable and the number of options is
>> such a mess.
>>
>>
>> Corinna
>>
>
> I am right now modifying setup to not sanitize CYGWIN away when invoking
> the post-install scripts and then will report back.
>
> Michael
>

Hmm, OK, changing script.cc to not strip out CYGWIN is trivial. But the
harder part is that main.cc uses ShellExecuteEx() with
SHELLEXECUTEINFO.verb set to "runas" in order to re-run setup elevated.
This resets all environment variables back to default. In my instance I can
circumvent this by passing --no-admin and running from an elevated shell
where CYGWIN is set already. And indeed, this works and resolves my Docker
problem. I attached this fix as a patch. But on the other hand, I find this
behavior to be a bit confusing. However, I don't see an easy way of
resolving the "runas" issue, because it is by design. An option would be
that the calling process passes the CYGWIN variable as a command line
argument to the elevated process. But that is also ugly. What do you guys
think?

Michael
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple