DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 914023851C3D
Date: Mon, 20 Jul 2020 09:55:58 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Marc Hoersken <info@marc-hoersken.de>
Subject: Re: [PATCH] Fix poll/select signal socket as write ready on connect
 failure
Message-ID: <20200720075558.GD16360@calimero.vinschen.de>
Mail-Followup-To: Marc Hoersken <info@marc-hoersken.de>, cygwin@cygwin.com
References: <efcd7b07-ccc3-a8a4-04c1-94f63012f042@marc-hoersken.de>
 <20200716092553.GA3784@calimero.vinschen.de>
 <8092a464-53a1-b74a-04f1-4d95a242c2b3@marc-hoersken.de>
 <20200717192140.GC16360@calimero.vinschen.de>
 <7ec397c4-dc25-407c-7925-d61382e80f8a@marc-hoersken.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <7ec397c4-dc25-407c-7925-d61382e80f8a@marc-hoersken.de>
Precedence: list
Reply-To: cygwin@cygwin.com
Cc: cygwin@cygwin.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces@cygwin.com
Sender: "Cygwin" <cygwin-bounces@cygwin.com>

On Jul 17 21:33, Marc Hoersken via Cygwin wrote:
> Hi Corinna,
> 
> Am 17.07.2020 um 21:21 schrieb Corinna Vinschen:
> > I don't agree here.  The sole purpose for connect_errorcode is to set
> > SOL_SOCKET/SO_ERROR in case a caller requests FD_CONNECT and FD_CONNECT
> > is available.  After being set once, SOL_SOCKET/SO_ERROR should not be
> > rewritten, given the description of SO_ERROR in `man 7 socket':
> > 
> >      SO_ERROR
> > 	  Get and clear the pending socket error.  This socket  option  is
> > 	      ^^^^^^^^^
> > 	  read-only.  Expects an integer.
> > 
> > [...]
> > 
> > Make sense?
> 
> 
> yes, this makes sense. Please go for it.

Great, done!

> Is there a public changelog I can check regulary to see if this has been
> released (once it is)? Thanks!

git log?  Or do you mean official Cygwin releases?  The only public
changelog is the announcement on cygwin-announce in this case.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple